Skip to content

Keep Windows signing process ownership through cleanup - #793

Draft
mashfromband wants to merge 3 commits into
mainfrom
codex/passshare-signing-owned-process
Draft

mashfromband wants to merge 3 commits into
mainfrom
codex/passshare-signing-owned-process

Conversation

@mashfromband

@mashfromband mashfromband commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

The Windows candidate build and updater signer launch PowerShell and other tools as a process tree. When a deadline expires, terminating only the immediate command can leave a signing descendant running after the caller returns.

This draft assigns Windows commands to an owned job before resuming them, waits for the captured members and output readers, and reports unconfirmed recovery separately. It includes a controlled child-process regression fixture and a legacy root-only control. The non-Windows command path is unchanged.

Validation: at head 93e5f27 the repository pull request workflows completed successfully, including the Windows desktop build smoke job, whose go test -mod=readonly ./... run for tools/desktop-release-check passed (https://github.com/AutoDevJapan/PassShare/actions/runs/43552840764). The controlled legacy root-only comparison is kept out of normal builds, so that run does not cover it; it still has to be run separately before review closure. No production signing, installer publication, deployment or credential change has been performed.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant