Repository navigation
Keep Windows signing process ownership through cleanup - #793
Draft
mashfromband wants to merge 3 commits into
Draft
mashfromband wants to merge 3 commits into
mashfromband wants to merge 3 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Windows candidate build and updater signer launch PowerShell and other tools as a process tree. When a deadline expires, terminating only the immediate command can leave a signing descendant running after the caller returns.
This draft assigns Windows commands to an owned job before resuming them, waits for the captured members and output readers, and reports unconfirmed recovery separately. It includes a controlled child-process regression fixture and a legacy root-only control. The non-Windows command path is unchanged.
Validation: at head 93e5f27 the repository pull request workflows completed successfully, including the Windows desktop build smoke job, whose
go test -mod=readonly ./...run fortools/desktop-release-checkpassed (https://github.com/AutoDevJapan/PassShare/actions/runs/43552840764). The controlled legacy root-only comparison is kept out of normal builds, so that run does not cover it; it still has to be run separately before review closure. No production signing, installer publication, deployment or credential change has been performed.