Merged
Conversation
Member
|
The reasoning here is a little aspirational, but it's basically this:
That said, our CLI applications don't really live up to this standard and I think most of them just override it themselves. In general, though, we like to keep the config strict for new projects and to motivate older projects to improve. This could all be made much more clear, of course, in the README and maybe comments in this preset. If you wanted to add that it would be much appreciated! |
Contributor
Author
|
Yeah, I can update the readme :) Hm, I think I follow. Seems like this preset is more oriented towards customer-facing CLI tools rather than assorted node scripts, which makes sense. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Edit: I've updated this to just clarify the readme.
I used the CLI config in a different repo (see https://github.com/Automattic/vip-go-utility-scripts/pull/477), but was surprised that using
console.logstill showed warnings. (The readme also implies that this rule is disabled here: https://github.com/Automattic/eslint-config-wpvip?tab=readme-ov-file#cli)Any objections to disabling the
no-consolerule for the CLI preset?