Fix Facebook embed parsing for legacy XFBML format#761
Merged
Conversation
The triggerOembedLoad function previously only called FB.XFBML.parse() when it found elements with the `.fb-post` CSS class. This caused Facebook embeds using the legacy XFBML format (`<fb:post>`) to not render, as the CSS selector wouldn't match namespace elements. Changes: - Remove the `.fb-post` element check before calling FB.XFBML.parse() - Always call FB.XFBML.parse(element) when Facebook SDK is available - Pass element parameter to scope parsing to the current container - Add comprehensive Jest tests for triggerOembedLoad function The Facebook SDK's XFBML.parse() handles both modern HTML5 format (`<div class="fb-post">`) and legacy XFBML format (`<fb:post>`), so removing the check makes the code more robust for cached embeds from older liveblog entries. Fixes #306 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<fb:post>).fb-postclass didn't match XFBML namespace elementsFB.XFBML.parse(element)when SDK is available, which handles both formatsBackground
Issue #306 reported Facebook embeds not rendering consistently. Investigation revealed that when oEmbed cached content in the legacy XFBML format (
<fb:post href="..." data-width="552">), the JavaScript checkelement.querySelector('.fb-post')would fail because:.fb-postis a CSS class selector<fb:post>is an XML namespace element, not a classThe Facebook SDK's
XFBML.parse()function handles both formats, so removing the element check and always calling parse when the SDK is loaded makes the code more robust.Test plan
triggerOembedLoadfunctionFixes #306
🤖 Generated with Claude Code