Skip to content

feat(rss): Skip non-distributable images#4052

Merged
Takshil-Kunadia merged 3 commits intotrunkfrom
feat/rss-remove-non-distributable-images
Jul 1, 2025
Merged

feat(rss): Skip non-distributable images#4052
Takshil-Kunadia merged 3 commits intotrunkfrom
feat/rss-remove-non-distributable-images

Conversation

@Takshil-Kunadia
Copy link
Copy Markdown
Collaborator

@Takshil-Kunadia Takshil-Kunadia commented Jun 27, 2025

All Submissions:

Changes proposed in this Pull Request:

Closes https://app.asana.com/1/26890605006346/project/1210562189110460/task/1210629622176531?focus=true .

Adds a new option to RSS feeds that allows publishers to exclude non-distributable images from feed content. The filtering of content uses the same logic as the RTT plugin.

How to test the changes in this Pull Request:

  1. Create a post and add few images - Make sure to add distributable (Can distribute? checked on media) & non-distributable images.
  2. Create Feeds from Admin > RSS Feeds.
  3. Check for new option - Remove non-distributable images.
  4. Enable the option > Click Update > Open the feed url.
  5. Check the Distributable image is appearing and non-distributable image is skipped.
  6. Also test this option is available only when RTT plugin is active.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@Takshil-Kunadia Takshil-Kunadia marked this pull request as ready for review June 27, 2025 11:55
@Takshil-Kunadia Takshil-Kunadia requested a review from a team as a code owner June 27, 2025 11:55
@leogermani leogermani added the [Status] Needs Review The issue or pull request needs to be reviewed label Jun 27, 2025
leogermani
leogermani reviewed Jun 27, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@leogermani leogermani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we avoid code duplication and create a remove_non_distrubutable_images( $content ) method in the Republication_Tracker_Tool_Content in the RTT plugin, and use that instead?

Just need to extract the part of the code in get_republishable_content that does that

@Takshil-Kunadia Takshil-Kunadia force-pushed the feat/rss-remove-non-distributable-images branch from 0ba8880 to 35a05d9 Compare June 28, 2025 09:18
@Takshil-Kunadia Takshil-Kunadia mentioned this pull request Jun 28, 2025
Merged
@Takshil-Kunadia
Copy link
Copy Markdown
Collaborator Author

Takshil-Kunadia commented Jun 28, 2025

Hi @leogermani, I have implemented the changes. Extracted the image extraction logic into a separate method. Also refactore class-media to separate concerns as "Media distribution" setting of RTT was interfering with the functionality implemented via this PR.

Please do have a look & review of this :- Automattic/republication-tracker-tool#258

Before reviewing this PR 🙇 .Thanks

@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Jul 1, 2025
@Takshil-Kunadia Takshil-Kunadia merged commit 9fdfe78 into trunk Jul 1, 2025
8 checks passed
@Takshil-Kunadia Takshil-Kunadia deleted the feat/rss-remove-non-distributable-images branch July 1, 2025 14:53
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 1, 2025

Hey @Takshil-Kunadia, good job getting this PR merged! 🎉

Now, the needs-changelog label has been added to it.

Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label.

If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label.

Thank you! ❤️

matticbot pushed a commit that referenced this pull request Jul 3, 2025
@semantic-release-bot
chore(release): 6.12.0-alpha.1 [skip ci]
31e9e91 
# [6.12.0-alpha.1](v6.11.2...v6.12.0-alpha.1) (2025-07-03)

### Bug Fixes

* **menu:** don't hide sponsors menu if the user can't see the newspack dashboard ([#4041](#4041)) ([f988bd2](f988bd2))
* saving name when registering user ([#4050](#4050)) ([498028e](498028e))
* **woocommerce-memberships:** prevent membership expiry if there's another active subscription ([#4009](#4009)) ([6b42cbd](6b42cbd))

### Features

* **capabilities:** add caps for RSS Feeds ([#3908](#3908)) ([2620c54](2620c54))
* **collections:** add hierarchical fields ([#4051](#4051)) ([3f5a704](3f5a704))
* **collections:** allow overriding "collection" names and slugs ([#4033](#4033)) ([f5523b0](f5523b0))
* **collections:** support multiple CTAs in collections meta ([#4049](#4049)) ([d445444](d445444))
* modal checkout for My Account's reorders ([#3988](#3988)) ([fd347bc](fd347bc))
* **my-account:** subscription payment notice ([#4029](#4029)) ([4b78d7f](4b78d7f))
* **rss:** Custom Tracking snippet ([#4047](#4047)) ([2e682c5](2e682c5))
* **rss:** Hooks extending RSS ([#4055](#4055)) ([da97ff4](da97ff4))
* **rss:** Skip non-distributable images ([#4052](#4052)) ([9fdfe78](9fdfe78))
* show "deleted" label on segments if list, subscription, or plan was deleted [NPPM-2031] ([#4021](#4021)) ([4dec8bb](4dec8bb))
* **woocommerce:** rename WooCommerce Payments to WooPay ([#4048](#4048)) ([1528cad](1528cad))
@matticbot
Copy link
Copy Markdown
Contributor

matticbot commented Jul 3, 2025

🎉 This PR is included in version 6.12.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Jul 14, 2025
@semantic-release-bot
chore(release): 6.12.0 [skip ci]
d3471ee 
# [6.12.0](v6.11.3...v6.12.0) (2025-07-14)

### Bug Fixes

* **menu:** don't hide sponsors menu if the user can't see the newspack dashboard ([#4041](#4041)) ([f988bd2](f988bd2))
* saving name when registering user ([#4050](#4050)) ([498028e](498028e))
* **woocommerce-memberships:** prevent membership expiry if there's another active subscription ([#4009](#4009)) ([6b42cbd](6b42cbd))

### Features

* **capabilities:** add caps for RSS Feeds ([#3908](#3908)) ([2620c54](2620c54))
* **collections:** add hierarchical fields ([#4051](#4051)) ([3f5a704](3f5a704))
* **collections:** allow overriding "collection" names and slugs ([#4033](#4033)) ([f5523b0](f5523b0))
* **collections:** support multiple CTAs in collections meta ([#4049](#4049)) ([d445444](d445444))
* modal checkout for My Account's reorders ([#3988](#3988)) ([fd347bc](fd347bc))
* **my-account:** subscription payment notice ([#4029](#4029)) ([4b78d7f](4b78d7f))
* **rss:** Custom Tracking snippet ([#4047](#4047)) ([2e682c5](2e682c5))
* **rss:** Hooks extending RSS ([#4055](#4055)) ([da97ff4](da97ff4))
* **rss:** Skip non-distributable images ([#4052](#4052)) ([9fdfe78](9fdfe78))
* show "deleted" label on segments if list, subscription, or plan was deleted [NPPM-2031] ([#4021](#4021)) ([4dec8bb](4dec8bb))
* **woocommerce:** rename WooCommerce Payments to WooPay ([#4048](#4048)) ([1528cad](1528cad))
@matticbot
Copy link
Copy Markdown
Contributor

matticbot commented Jul 14, 2025

🎉 This PR is included in version 6.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leogermani leogermani leogermani approved these changes

Assignees

No one assigned

Labels

released on @alpha released [Status] Approved The pull request has been reviewed and is ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Takshil-Kunadia @matticbot @leogermani