Skip to content

fix(dev-env): remove test env const check#1398

Open
naxoc wants to merge 1 commit intotrunkfrom
fix/remove-is-test-check
Open

fix(dev-env): remove test env const check#1398
naxoc wants to merge 1 commit intotrunkfrom
fix/remove-is-test-check

Conversation

@naxoc
Copy link
Member

@naxoc naxoc commented Feb 18, 2025

All Submissions:

Changes proposed in this Pull Request:

This is a tiny PR to get rid of the check for IS_TEST_ENV. There are other ways to suppres the popups, so it is not necessary. It was messing with me because I needed that constant set for testing something else :)

Let's see if tests still work.

How to test the changes in this Pull Request:

  1. Not much to test – take a look at the code

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@naxoc naxoc self-assigned this Feb 18, 2025
@naxoc naxoc requested a review from a team as a code owner February 18, 2025 14:39
@naxoc
Copy link
Member Author

naxoc commented Feb 18, 2025

Hm. Not sure I understand why the tests fail. They don't locally. It looks like the dist-folder is not present on Circle. I'll get back to this.

@dkoo
Copy link
Contributor

dkoo commented Feb 18, 2025

Strange how the tests run fine locally. Might have something to do with our CI jobs?

@naxoc
Copy link
Member Author

naxoc commented Feb 20, 2025

This is not super high priority, but I would like to figure out the discrepancy. It looks like the tests are run before the JS stuff is built on Circle. I took a look at the config and it looks very similar to the one on newspack-plugin for instance 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants