Open
Conversation
Member
Author
|
Hm. Not sure I understand why the tests fail. They don't locally. It looks like the dist-folder is not present on Circle. I'll get back to this. |
Contributor
|
Strange how the tests run fine locally. Might have something to do with our CI jobs? |
Member
Author
|
This is not super high priority, but I would like to figure out the discrepancy. It looks like the tests are run before the JS stuff is built on Circle. I took a look at the config and it looks very similar to the one on newspack-plugin for instance 🤔 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
This is a tiny PR to get rid of the check for
IS_TEST_ENV. There are other ways to suppres the popups, so it is not necessary. It was messing with me because I needed that constant set for testing something else :)Let's see if tests still work.
How to test the changes in this Pull Request:
Other information: