fix: run do_shortcode on manual, custom placements for the block theme

[laurelfulford]

All Submissions:

• Have you followed the Newspack Contributing guideline?
• Does your code follow the WordPress' coding standards and VIP Go coding standards?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

While Single Prompt and Custom Placements still work in the post/page content using the block theme, it absolutely does not want to do anything with the shortcode these placements use when placed in a template/template part via the site editor.

This PR adds a check for the block theme and the content, and runs do_shortcode() when you're using the block theme and not in the content, rather than inserting the shortcode block code directly. Both Copilot and Cursor suggested using a filter to make it easier to swap between these two "themes" for testing, so I went with that, too 😅

I think this is kind of a temporary measure; NPPD-1216 proposes some changes to campaigns to make them more "block-like".

Closes NPPD-1212

How to test the changes in this Pull Request:

1. Set up a couple prompts, one manual and one custom placement.
2. If it's not already running the block theme, switch your site to the block theme.
3. Edit the Site, and add a Single Placement and Custom Placement block, and add your campaign prompts to them.
4. View on the front-end:

5. Apply this PR.
6. Refresh the page and confirm you're getting prompts:

7. Try adding the two manual placements in post/page content, and ensure they still work.
8. Switch to the Classic theme and try adding both placements to the content and widget areas, respectively.

Other information:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes, as applicable?
• Have you successfully ran tests with your changes locally?

[Copilot]

Pull request overview

This PR addresses prompt blocks not rendering when inserted into block-theme templates/template parts by changing how the underlying [newspack-popup] shortcode is executed in dynamic block render callbacks.

Changes:

• Detect block themes and render the prompt via do_shortcode() instead of returning a wp:shortcode block comment wrapper.
• Apply the same logic to both the Single Prompt block and the Custom Placement block renderers.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.

File	Description
src/blocks/single-prompt/view.php	Adds block-theme detection and renders the prompt shortcode directly for block themes.
src/blocks/custom-placement/view.php	Mirrors the block-theme shortcode rendering change for custom placement prompts.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[miguelpeixe]

Good solution and tests well!

[laurelfulford]

Yay! Thanks @miguelpeixe! 🙌 😄

[github-actions]

Hey @laurelfulford, good job getting this PR merged! 🎉

Now, the needs-changelog label has been added to it.

Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label.

If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label.

Thank you! ❤️

[github-actions]

🎉 This PR is included in version 3.10.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[github-actions]

🎉 This PR is included in version 3.10.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀