Skip to content

[Pro] Sidebar Panel: Loading indicator not showing in group search options on early search #7891

@Drivingralle

Description

@Drivingralle

I hope it's fine to add an issue for the Pro-Version here.

Steps to Reproduce

  1. Requires a Website with Sensei Pro.
  2. Have a big amount of groups available
  3. Add/edit a lession
  4. Select a block
  5. Open the sidebar panel to set block visibility
  6. Click into the Group field and start typing imideatly
  7. The options list says "no student group available"
  8. After waiting a while the availiable group is found and show inside the options list. Without doing anything
Image

Best to test on a slow connection.

What I Expected

I was expacting a loading indicator even if I start searching for a group before the list has been lazy loaded.

What Happened Instead

Just clicking into the group field shows an "ok" loading indicator. That is replaced with a false "empty results" if an editor starts typing a search value before the data for the list of groups is lazy loaded.

The data store seams to handle the data well as soon as they come in. No need to trigger the search again after the list data have been loaded.

Lazy loading the groups is a good idea in general.

PHP / WordPress / Sensei LMS version

WP 6.9.1
Sensei 4.25.2
Sensei Pro 1.24.5

Browser / OS version

FF on MacOS (booth latest)

Screenshot / Video

Context / Source

I'm managing a online acadamy over mobile data from a rulral tropical place that loads to long load times for all kind of resources.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions