Populate parent_post_id in HPPS progress table

[donnapep]

Summary

This prepares the data model for reusable lessons by storing hierarchy relationships directly in the sensei_lms_progress table, eliminating the need for postmeta joins.

This data wasn't populated prior to shipping HPPS, so it needs to be backfilled for those sites that have it enabled and are actively syncing between comments and custom tables.

• Adds an optional $parent_post_id parameter to all progress repository create() interfaces and implementations (backward-compatible, defaults to null)
• Updates all callers (Sensei_Utils::user_start_lesson(), Sensei_Quiz, Sensei_Grading) to look up and pass the parent ID: course ID for lesson progress, lesson ID for quiz progress
• Updates the comments-to-tables Student_Progress_Migration to populate parent_post_id during initial migration
• Adds a new Parent_Post_Id_Migration backfill job for existing HPPS sites that already have progress rows with NULL parent_post_id

Test plan

Automated tests

• vendor/bin/phpunit --filter=testCreate_WhenParentPostIdProvided — verifies both lesson and quiz repositories store parent_post_id
• vendor/bin/phpunit --filter=Parent_Post_Id_Migration_Test — 8 tests covering backfill migration (batching, idempotency, orphaned rows, completion)
• vendor/bin/phpunit --filter=testRun_WithLessonAndQuiz_PopulatesParentPostId — verifies comments-to-tables migration populates parent_post_id
• vendor/bin/phpunit --filter=testBackfillParentPostId — 5 tests covering upgrade handler conditions

Manual testing — new progress creation

1. Set up a local site with HPPS enabled (Sensei > Settings > Experimental Features > High Performance Progress Storage)
2. Create a course with a lesson and a quiz
3. Enroll a student and have them start the lesson
4. Check the sensei_lms_progress table:

   SELECT id, post_id, parent_post_id, type FROM wp_sensei_lms_progress ORDER BY id DESC;

5. Verify:
   • Lesson progress row has parent_post_id = the course ID
   • Quiz progress row (if quiz was started) has parent_post_id = the lesson ID
   • Course progress row has parent_post_id = NULL

Manual testing — backfill migration

1. On a site with HPPS enabled and existing progress data, null out parent_post_id to simulate pre-existing rows:

   UPDATE wp_sensei_lms_progress SET parent_post_id = NULL WHERE type IN ('lesson', 'quiz');
   SELECT COUNT(*) FROM wp_sensei_lms_progress WHERE parent_post_id IS NULL AND type IN ('lesson', 'quiz');

2. Trigger the upgrade handler by decrementing the stored version:

   wp option update sensei-version 4.25.0

3. Visit any admin page — run_updates() fires and schedules the Action Scheduler job (sensei_lms_migration_job_parent_post_id_migration)
4. Run the scheduled action:

   wp action-scheduler run

5. After migration completes, verify NULL count is 0 (or only orphaned records with no postmeta):

   SELECT COUNT(*) FROM wp_sensei_lms_progress WHERE parent_post_id IS NULL AND type IN ('lesson', 'quiz');

6. Verify values are correct:

   -- Lesson progress: parent_post_id should match _lesson_course meta
   SELECT p.id, p.post_id AS lesson_id, p.parent_post_id, pm.meta_value AS expected_course_id
   FROM wp_sensei_lms_progress p
   LEFT JOIN wp_postmeta pm ON pm.post_id = p.post_id AND pm.meta_key = '_lesson_course'
   WHERE p.type = 'lesson' AND p.parent_post_id IS NOT NULL;
   
   -- Quiz progress: parent_post_id should match _quiz_lesson meta
   SELECT p.id, p.post_id AS quiz_id, p.parent_post_id, pm.meta_value AS expected_lesson_id
   FROM wp_sensei_lms_progress p
   LEFT JOIN wp_postmeta pm ON pm.post_id = p.post_id AND pm.meta_key = '_quiz_lesson'
   WHERE p.type = 'quiz' AND p.parent_post_id IS NOT NULL;

7. • Confirm parent_post_id matches the expected value from postmeta in both queries

🤖 Generated with Claude Code

[Copilot]

Pull request overview

Adds support for persisting hierarchy relationships in HPPS progress rows by populating sensei_lms_progress.parent_post_id (course for lesson progress; lesson for quiz progress) and introduces a backfill migration to populate existing rows.

Changes:

• Extends lesson/quiz progress repository create() APIs to accept an optional $parent_post_id and stores it in table-based progress rows.
• Updates key progress-creation callers and the comments-to-tables Student_Progress_Migration to populate parent_post_id.
• Adds a new Parent_Post_Id_Migration and corresponding unit tests for backfilling existing HPPS rows.

Reviewed changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
tests/unit-tests/internal/student-progress/quiz-progress/repositories/test-class-tables-based-quiz-progress-repository.php	Adds coverage that quiz progress create() persists parent_post_id.
tests/unit-tests/internal/student-progress/lesson-progress/repositories/test-class-tables-based-lesson-progress-repository.php	Adds coverage that lesson progress create() persists parent_post_id.
tests/unit-tests/internal/migration/migrations/test-class-student-progress-migration.php	Adds test ensuring comments-to-tables migration sets parent_post_id for course/lesson/quiz progress.
tests/unit-tests/internal/migration/migrations/test-class-parent-post-id-migration.php	Introduces unit tests for the new parent_post_id backfill migration behavior.
includes/internal/student-progress/quiz-progress/repositories/class-tables-based-quiz-progress-repository.php	Adds optional $parent_post_id to create() and writes it to the HPPS table.
includes/internal/student-progress/quiz-progress/repositories/class-table-reading-aggregate-quiz-progress-repository.php	Threads $parent_post_id through aggregate create() and ensures lesson progress creation passes course parent.
includes/internal/student-progress/quiz-progress/repositories/class-quiz-progress-repository-interface.php	Updates repository interface to accept optional $parent_post_id.
includes/internal/student-progress/quiz-progress/repositories/class-comments-based-quiz-progress-repository.php	Updates method signature for interface compatibility (parameter unused).
includes/internal/student-progress/quiz-progress/repositories/class-comment-reading-aggregate-quiz-progress-repository.php	Threads $parent_post_id through aggregate create().
includes/internal/student-progress/lesson-progress/repositories/class-tables-based-lesson-progress-repository.php	Adds optional $parent_post_id to create() and writes it to the HPPS table.
includes/internal/student-progress/lesson-progress/repositories/class-table-reading-aggregate-lesson-progress-repository.php	Threads $parent_post_id through aggregate create().
includes/internal/student-progress/lesson-progress/repositories/class-lesson-progress-repository-interface.php	Updates repository interface to accept optional $parent_post_id.
includes/internal/student-progress/lesson-progress/repositories/class-comments-based-lesson-progress-repository.php	Updates method signature for interface compatibility (parameter unused).
includes/internal/student-progress/lesson-progress/repositories/class-comment-reading-aggregate-lesson-progress-repository.php	Threads $parent_post_id through aggregate create().
includes/internal/migration/migrations/class-student-progress-migration.php	Populates parent_post_id during initial comments-to-tables migration.
includes/internal/migration/migrations/class-parent-post-id-migration.php	Adds new backfill migration to populate missing parent_post_id for lesson/quiz progress rows.
includes/class-sensei.php	Registers the new migration job with the migration scheduler.
includes/class-sensei-utils.php	Passes course ID into lesson progress creation to populate parent_post_id.
includes/class-sensei-quiz.php	Passes course/lesson parents into progress creation paths for grading/quiz start.
includes/class-sensei-grading.php	Passes course ID into lesson progress creation during grading flow.
changelog/add-hpps-parent-post-id	Adds changelog entry for the new HPPS parent_post_id population behavior.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

[Copilot]

Pull request overview

Copilot reviewed 25 out of 25 changed files in this pull request and generated 4 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

[donnapep]

👋🏻 @merkushin

[merkushin]

Sorry, almost missed the notification in my inbox 😅

The changes look good. But I haven't tested it locally.

It's interesting to notice that tests (with clear structure and names) become a better tool for understanding code. The generated code, on the other hand, becomes less readable (code nesting really affects it).

A couple of weeks ago, I read about an observation that in the modern world, code could be entirely open since the cost of writing it is extremely low, but the tests' value increases, and they might become closed source.

[mdawaffe]

A couple super minor things, but looks good to me. I didn't test locally :(