Skip to content

Revert "Sync HPPS parent_post_id when a lesson is reassigned"#7950

Merged
donnapep merged 1 commit into
trunkfrom
revert-7939-fix/hpps-lesson-course-sync
Apr 21, 2026
Merged

Revert "Sync HPPS parent_post_id when a lesson is reassigned"#7950
donnapep merged 1 commit into
trunkfrom
revert-7939-fix/hpps-lesson-course-sync

Conversation

@donnapep
Copy link
Copy Markdown
Member

Reverts #7939 based on this discussion - #7931 (comment).

@donnapep donnapep added this to the 4.26.0 milestone Apr 21, 2026
@donnapep donnapep self-assigned this Apr 21, 2026
Copilot AI review requested due to automatic review settings April 21, 2026 23:49
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Reverts the previously added HPPS behavior that synced sensei_lms_progress.parent_post_id for lesson progress rows when a lesson’s _lesson_course postmeta changed.

Changes:

  • Removes Lesson_Course_Sync_Handler (the postmeta hook handler that updated parent_post_id for lesson progress rows).
  • Removes the unit test suite that covered the handler behavior.
  • Removes the associated changelog entry and a related documentation line in AGENTS.md.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
includes/internal/student-progress/services/class-lesson-course-sync-handler.php Deletes the service that listened for _lesson_course meta changes and updated HPPS progress rows.
includes/class-sensei.php Removes initialization/wiring of the deleted sync handler.
tests/unit-tests/internal/student-progress/services/test-class-lesson-course-sync-handler.php Deletes unit tests that validated the sync behavior.
changelog/fix-hpps-lesson-course-sync Removes the changelog entry that documented the added sync behavior.
AGENTS.md Removes a testing-conventions bullet (assertion messages).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread includes/class-sensei.php
Comment thread AGENTS.md
@donnapep donnapep merged commit 0ed3ce2 into trunk Apr 21, 2026
30 checks passed
@donnapep donnapep deleted the revert-7939-fix/hpps-lesson-course-sync branch April 21, 2026 23:58
@donnapep donnapep removed this from the 4.26.0 milestone Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants