Revert "Sync HPPS parent_post_id when a lesson is reassigned"#7950
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Reverts the previously added HPPS behavior that synced sensei_lms_progress.parent_post_id for lesson progress rows when a lesson’s _lesson_course postmeta changed.
Changes:
- Removes
Lesson_Course_Sync_Handler(the postmeta hook handler that updatedparent_post_idfor lesson progress rows). - Removes the unit test suite that covered the handler behavior.
- Removes the associated changelog entry and a related documentation line in
AGENTS.md.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
includes/internal/student-progress/services/class-lesson-course-sync-handler.php |
Deletes the service that listened for _lesson_course meta changes and updated HPPS progress rows. |
includes/class-sensei.php |
Removes initialization/wiring of the deleted sync handler. |
tests/unit-tests/internal/student-progress/services/test-class-lesson-course-sync-handler.php |
Deletes unit tests that validated the sync behavior. |
changelog/fix-hpps-lesson-course-sync |
Removes the changelog entry that documented the added sync behavior. |
AGENTS.md |
Removes a testing-conventions bullet (assertion messages). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #7939 based on this discussion - #7931 (comment).