Ensure _get_function_full_qual_name() can get always get the module name#62
Merged
trangevi merged 2 commits intoAzure:masterfrom Apr 13, 2022
ysmu:master
Merged
Ensure _get_function_full_qual_name() can get always get the module name#62trangevi merged 2 commits intoAzure:masterfrom ysmu:master
trangevi merged 2 commits intoAzure:masterfrom
ysmu:master
Conversation
…e module is imported through importlib
trangevi
previously approved these changes
Apr 13, 2022
trangevi
approved these changes
Apr 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_get_function_full_qual_name()cannot correctly detect the module name when if module is not available insys.modulesdue to howinspect.getmodule()is implemented. Since we only need the module name, updating the function to read from__module__.