[BUG] Can't run waagent -deprovision

[Bug-Reaper]

Describe the bug: A clear and concise description of what the bug is.

1. Install the AUR for WALinuxAgent https://aur.archlinux.org/packages/walinuxagent/
2. Attempt to run waagent --deprovision (as root)
3. ???
   

Distro and WALinuxAgent details:

• Arch Linux (Latest)
• WALinuxAgent version (2.2.46)
• Python 3.8.2

[Bug-Reaper]

Can I just manually delete all this stuff?

All SSH host keys (if Provisioning.RegenerateSshHostKeyPair is 'y' in the configuration file)

Nameserver configuration in /etc/resolv.conf

Root password from /etc/shadow (if Provisioning.DeleteRootPassword is 'y' in the configuration file)

Cached DHCP client leases

Resets host name to localhost.localdomain

Docs clearly state that waagent -deprovision is not guaranteed to delete everything required and that users should also be manually deleting things if possible/warranted.

[Bug-Reaper]

Alright, I got this figured out. Not sure if this is specific to Arch Linux, I'd imagine it applies to any *Nix system using the latest dhcpcd.

What you need to do is (as root):

systemctl stop dhcpcd
umount /var/lib/dhcpcd/run/systemd/journal
umount /var/lib/dhcpcd/run/udev
umount /var/lib/dhcpcd/sys
umount /var/lib/dhcpcd/dev
umount /var/lib/dhcpcd/proc

After which you can run waagent -deprovision successfully without it spitting out a stack trace in the python.

The underlying issue is clearly that waagent is trying to remove directories that not even root cannot remove. You must run the umounts listed above first.

Apparently those are now mounted by dhcpcd ONTOP of where they originally were. As in, unmounting them doesn't remove files from those locations. Very strange.

I'd be happy to make a PR which automates this process as part of agent.py. None of those commands are going to break the waagent -deprovison process regardless of what *nix OS you're on and we could obviously try to detect that we're on a system that requires this first.

Cheers

[pgombar]

Hi @Bug-Reaper thank you for your analysis. Feel free to submit a PR to improve this and reference this issue. cc @trstringer

[Bug-Reaper]

@pgombar @trstringer I'll try to get a PR up for this and test it out over the next couple of days. Thanks :)

[Bug-Reaper]

The PR is up, let me know what you think @trstringer 👍