Add switch to turn redundant log file off#1819
Open
pmjdebruijn wants to merge 1 commit intoAzure:developfrom
Open
Add switch to turn redundant log file off#1819pmjdebruijn wants to merge 1 commit intoAzure:developfrom
pmjdebruijn wants to merge 1 commit intoAzure:developfrom
Conversation
|
|
Codecov Report
@@ Coverage Diff @@
## develop #1819 +/- ##
===========================================
- Coverage 68.54% 68.54% -0.01%
===========================================
Files 82 82
Lines 11729 11732 +3
Branches 1644 1645 +1
===========================================
+ Hits 8040 8042 +2
Misses 3343 3343
- Partials 346 347 +1
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issue #1817 (this adds on option for the last part, without actually changing the default behavior)
Currently there is no way to disable logging to /var/log/waagent.log, which is redundant with the proper system log in journald.
This PR adds a configuration switch so it's easy to turn off logging to a file, and only have logging in journald.
PR information
Quality of Code and Contribution Guidelines
This change is