Use append mode in 'dd' when the desired swap size is not a multiple of 64M (#2286)#2601
Open
vittyvk wants to merge 3 commits intoAzure:developfrom
Open
Use append mode in 'dd' when the desired swap size is not a multiple of 64M (#2286)#2601vittyvk wants to merge 3 commits intoAzure:developfrom
vittyvk wants to merge 3 commits intoAzure:developfrom
Conversation
vittyvk
requested review from
ZhidongPeng,
dhivyaganesan,
kevinclark19a,
larohra,
nagworld9 and
narrieta
as code owners
Member
|
@anhvoms could you take a look? thanks |
Member
|
@vittyvk could you base your PR on the develop branch? |
…of 64M (Azure#2286) First 'dd' command creates the swap in multiples of 64M and the second is supposed to add the rest, however, with no 'oflag=append' it just overwrites what was already written so the file doesn't grow as desired. Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Codecov Report
@@ Coverage Diff @@
## develop #2601 +/- ##
========================================
Coverage 72.02% 72.03%
========================================
Files 103 103
Lines 15745 15746 +1
Branches 2501 2501
========================================
+ Hits 11341 11342 +1
Misses 3887 3887
Partials 517 517
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Contributor
Author
|
Ping? |
Member
|
@anhvoms - could you take a look? thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First 'dd' command creates the swap in multiples of 64M and the second
is supposed to add the rest, however, with no 'oflag=append' it just
overwrites what was already written so the file doesn't grow as desired.
Signed-off-by: Vitaly Kuznetsov vkuznets@redhat.com
Description
Issue #2286
PR information
Quality of Code and Contribution Guidelines