Drop the interpreter for execution in the service file#3286
Open
rjschwei wants to merge 1 commit intoAzure:developfrom
Open
Drop the interpreter for execution in the service file#3286rjschwei wants to merge 1 commit intoAzure:developfrom
rjschwei wants to merge 1 commit intoAzure:developfrom
Conversation
The waagent script is executable and has the interpreter set. Drop the use of the Python interpreter to execute the file from the systemd unit file. We achieve unbuffered I/O by setting the PYTHONUNBUFFERED environment variable instead. This makes it easier for distribution packaging as packagers will only have to update the pathto the interpreter used on the given distro in one file.
Member
|
@rjschwei - Extensions inherit the environment of the Agent. This change ended up breaking the Microsoft.CPlat.Core.LinuxPatchExtension extension since it changes the timing of the extension. Although this is actually a bug in the extension and a fix is currently being deployed, we do not know if other extensions have similar issues, plus not all VMs may be configured to take extension updates. The PR makes a change that applies to distros other than SUSE, so we consider it to be high risk. Probably it may be worth considering whether this change can be undone in SUSE, but if it cannot, we suggest updating this PR to apply only to SUSE. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The waagent script is executable and has the interpreter set. Drop the use of the Python interpreter to execute the file from the systemd unit file. We achieve unbuffered I/O by setting the PYTHONUNBUFFERED environment variable instead. This makes it easier for distribution packaging as packagers will only have to update the pathto the interpreter used on the given distro in one file.
Issue #
PR information
developbranch.Quality of Code and Contribution Guidelines