Fix issue #6991#6992
Closed
ferronsw wants to merge 1 commit into
Closed
Conversation
… SDK unmarshal bug
ferronsw
requested review from
JeffreyCA,
rajeshkamal5050,
tg-msft,
therealjohn,
trangevi,
trrwilson and
weikanglim
as code owners
microsoft-github-policy-service
Bot
added
the
customer-reported
Contributor
|
Thank you for your contribution @ferronsw! We will review the pull request and get back to you soon. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #6991 by changing how the Azure AI Agents extension enumerates Cognitive Services accounts when discovering Foundry projects, avoiding a known Azure SDK deserialization bug.
Changes:
- Switch Foundry project discovery from
armcognitiveservices.AccountsClientto the genericarmresources.Clientfor listing Cognitive Services accounts. - Add an OData
$filter(resourceType eq 'Microsoft.CognitiveServices/accounts') to scope the generic resources listing to the intended resource type.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm no go expert so please verify if this is a good solution.
It worked for me regarding #6991