Add raw flag to monitor command and implement log formatting for SSE on azd ai agent monitor#7210
Draft
therealjohn wants to merge 1 commit intoAzure:mainfrom
Draft
Add raw flag to monitor command and implement log formatting for SSE on azd ai agent monitor#7210therealjohn wants to merge 1 commit intoAzure:mainfrom
therealjohn wants to merge 1 commit intoAzure:mainfrom
Conversation
spboyer
reviewed
Mar 26, 2026
Member
spboyer
left a comment
There was a problem hiding this comment.
Code Review
1. Default formatting corrupts non-SSE container log lines
azure.ai.agents/internal/cmd/monitor.go:185, monitor_format.go:56 — Medium
The new formatter is applied to every monitor stream when --raw is not set, including the normal container logstream path (--session omitted). formatLine() drops lines starting with event: , strips the data: prefix from data lines, and suppresses blank lines. This means valid application logs like event: user_login, data: payload, or intentional blank separators are no longer shown verbatim.
Fix: Only apply SSE formatting to the session/SSE stream (or gate on response content type). Keep container logstream output raw by default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prototype for #7209.
Parse SSE/JSON output from monitor and format the results to be more compact and readable.
Include a
--rawflag which continues the existing behavior of just printing the raw SSE stream from the server.