fix: replace non-ASCII en-dash with ASCII hyphen in Update-AzFunction…#29680
Merged
Conversation
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
dolauli
approved these changes
May 25, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR replaces non-ASCII dash characters (e.g., en-dash/em-dash) with ASCII hyphens across several PowerShell cmdlet implementations and scenario/Pester tests to prevent PowerShell parsing/parameter-binding failures and improve consistency.
Changes:
- Replaced non-ASCII parameter-prefix dashes in multiple scenario tests (fixes commands that would otherwise fail to run).
- Replaced non-ASCII punctuation in comments/help text and a user-facing error message.
- Normalized several file headers/first lines where the non-ASCII characters appeared.
Reviewed changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/StackHCI/StackHCI.Autorest/test/StackHCI-Registration.Tests.ps1 | Replaces non-ASCII punctuation in a test comment. |
| src/StackHCI/StackHCI.Autorest/custom/stackhci.ps1 | Replaces non-ASCII punctuation in comments. |
| src/Sql/Sql.Test/ScenarioTests/FailoverGroupTests.ps1 | Fixes non-ASCII parameter-prefix dashes in test cmdlet invocations. |
| src/Sql/Sql.Test/ScenarioTests/ElasticPoolCrudTests.ps1 | Fixes non-ASCII parameter-prefix dash in a test cmdlet invocation. |
| src/SecurityInsights/SecurityInsights.Autorest/test/utils.ps1 | Replaces non-ASCII punctuation in a comment. |
| src/SecurityInsights/SecurityInsights.Autorest/test/Remove-AzSentinelDataConnector.Tests.ps1 | Replaces non-ASCII punctuation in a test comment. |
| src/Resources/Resources.Test/ScenarioTests/DenyAssignmentCrudTests.ps1 | Replaces non-ASCII punctuation in comments. |
| src/RecoveryServices/RecoveryServices.Backup.Test/ScenarioTests/AzureWorkload/ItemTests.ps1 | Fixes non-ASCII parameter-prefix dashes in piped cmdlet invocations. |
| src/Network/Network.Test/ScenarioTests/SecurityPartnerProviderTests.ps1 | Fixes non-ASCII parameter-prefix dashes in test cmdlet invocations. |
| src/Network/Network.Test/ScenarioTests/AzureFirewallTests.ps1 | Fixes non-ASCII parameter-prefix dashes in test cmdlet invocations. |
| src/Network/Network.Test/ScenarioTests/AzureFirewallIpGroupTests.ps1 | Fixes non-ASCII parameter-prefix dash in a test cmdlet invocation. |
| src/KeyVault/KeyVault.Test/Scripts/Common.ps1 | Fixes non-ASCII parameter-prefix dashes in filesystem cmdlets used by tests. |
| src/Functions/Functions.Autorest/test/Sanitize-Recordings.ps1 | Replaces non-ASCII punctuation in a comment. |
| src/Functions/Functions.Autorest/custom/Update-AzFunctionApp.ps1 | Replaces non-ASCII punctuation in a user-facing error message. |
| src/EdgeMarketplace/EdgeMarketplace.Autorest/custom/Request-AzEdgeMarketplaceOfferAccessToken.ps1 | Replaces non-ASCII punctuation in comment-based help text. |
| src/DynatraceObservability/DynatraceObservability.Autorest/test/New-AzDynatraceMonitoredSubscription.Tests.ps1 | Replaces non-ASCII punctuation in a test comment. |
| src/DnsResolver/DnsResolver.Autorest/test/utils.ps1 | Replaces non-ASCII character at file start (line impacted also contains path concatenation). |
| src/DnsResolver/DnsResolver.Autorest/test/New-AzDnsResolver.Tests.ps1 | Replaces non-ASCII punctuation in a test comment. |
| src/DataProtection/DataProtection.Autorest/custom/Helpers/PolicyHelpers.ps1 | Replaces non-ASCII punctuation in a comment. |
| src/CustomLocation/CustomLocation.Autorest/test/utils.ps1 | Fixes non-ASCII parameter-prefix dash in Start-Sleep usage. |
| src/AppConfiguration/AppConfigurationdata.Autorest/test/utils.ps1 | Replaces non-ASCII punctuation in a comment. |
| src/ApiManagement/ApiManagement.ServiceManagement.Test/ScenarioTests/ApiManagementTests.ps1 | Fixes non-ASCII parameter-prefix dashes across New-Object and Az cmdlet invocations in scenario tests. |
Comment on lines
2
to
+6
| .SYNOPSIS | ||
| This cmdlet combines New-AzEdgeMarketplaceOfferAccessToken and Get-AzEdgeMarketplaceOfferAccessToken to generate access token and retrieve the final SAS token when the disk is ready—enabling clients to download marketplace images to their edge devices. | ||
| This cmdlet combines New-AzEdgeMarketplaceOfferAccessToken and Get-AzEdgeMarketplaceOfferAccessToken to generate access token and retrieve the final SAS token when the disk is ready-enabling clients to download marketplace images to their edge devices. | ||
|
|
||
| .DESCRIPTION | ||
| This cmdlet combines New-AzEdgeMarketplaceOfferAccessToken and Get-AzEdgeMarketplaceOfferAccessToken to generate access token and retrieve the final SAS token when the disk is ready—enabling clients to download marketplace images to their edge devices. | ||
| This cmdlet combines New-AzEdgeMarketplaceOfferAccessToken and Get-AzEdgeMarketplaceOfferAccessToken to generate access token and retrieve the final SAS token when the disk is ready-enabling clients to download marketplace images to their edge devices. |
Comment on lines
+1
to
3
| ."$PSScriptRoot\testDataGenerator.ps1" | ||
| ."$PSScriptRoot\virtualNetworkClient.ps1" | ||
| ."$PSScriptRoot\stringExtensions.ps1" |
| if ($existingFunctionApp.Kind -and $existingFunctionApp.Kind.ToString() -match "azurecontainerapps") | ||
| { | ||
| $errorMessage = "Update-AzFunctionApp does not support updating Container Apps–hosted function apps." | ||
| $errorMessage = "Update-AzFunctionApp does not support updating Container Apps-hosted function apps." |
Pan-Qi
approved these changes
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…App.ps1
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.