Skip to content

[Storage File] preserve content type header#43325

Open
gracewilcox wants to merge 5 commits into
Azure:mainfrom
gracewilcox:contenttype
Open

[Storage File] preserve content type header#43325
gracewilcox wants to merge 5 commits into
Azure:mainfrom
gracewilcox:contenttype

Conversation

@gracewilcox
Copy link
Copy Markdown
Member

Adding decorator to keep Content-Type headers for specific operation in Go to preserve back compatibility

@microsoft-github-policy-service microsoft-github-policy-service Bot added the Storage Storage Service (Queues, Blobs, Files) label May 19, 2026
@gracewilcox gracewilcox marked this pull request as ready for review May 19, 2026 00:46
@gracewilcox gracewilcox requested a review from seanmcc-msft as a code owner May 19, 2026 00:46
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 19, 2026

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR targets either the main branch of the public specs repo or the RPSaaSMaster branch of the private specs repo. These branches are not intended for iterative development. Therefore, you must acknowledge you understand that after this PR is merged, the APIs are considered shipped to Azure customers. Any further attempts at in-place modifications to the APIs will be subject to Azure's versioning and breaking change policies. Additionally, for control plane APIs, you must acknowledge that you are following all the best practices documented by ARM at aka.ms/armapibestpractices. If you do intend to release the APIs to your customers by merging this PR, add the PublishToCustomers label to your PR in acknowledgement of the above. Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ The required check named TypeSpec Validation has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide


Comment generated by summarize-checks workflow run.

@github-actions github-actions Bot added data-plane TypeSpec Authored with TypeSpec labels May 19, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 19, 2026

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
TypeSpec Storage.File
Python azure-storage-file-share
JavaScript @azure/storage-file-share

Comment generated by After APIView workflow run.

@@clientName(UserDelegationKey.signedTid, "SignedTID", "go");
#suppress "@azure-tools/typespec-client-generator-core/client-option"
@@clientOption(HandleItem, "omitSerdeMethods", "all", "go");
@@clientOption(Directory.listFilesAndDirectoriesSegment,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably need a suppression over each decorator

Copy link
Copy Markdown
Member

@catalinaperalta catalinaperalta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to get tsp validation passing before this can get merged in, look at the check for info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data-plane Storage Storage Service (Queues, Blobs, Files) TypeSpec Authored with TypeSpec

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants