Skip to content

Comments

Update UnbrandedGeneratorVersion to 1.0.0-alpha.20260219.3#56363

Merged
jorgerangel-msft merged 4 commits intotypespec/update-http-client-1.0.0-alpha.20260219.3from
copilot/sub-pr-56357
Feb 20, 2026
Merged

Update UnbrandedGeneratorVersion to 1.0.0-alpha.20260219.3#56363
jorgerangel-msft merged 4 commits intotypespec/update-http-client-1.0.0-alpha.20260219.3from
copilot/sub-pr-56357

Conversation

Copy link
Contributor

Copilot AI commented Feb 20, 2026

Updates the TypeSpec HTTP Client C# generator from 1.0.0-alpha.20260219.2 to 1.0.0-alpha.20260219.3. Triggered by: microsoft/typespec@dd866a7

Description

  • eng/Packages.Data.props — bumped UnbrandedGeneratorVersion
  • eng/packages/http-client-csharp/package.json — bumped @typespec/http-client-csharp dependency; ran npm install to update lock file
  • XmlSerializableVisitor.cs — updated to handle the generator's renamed private helper method (WriteWriteXml): the explicit IXmlSerializable.Write interface method remains unchanged and delegates to the renamed private WriteXml helper; introduced named constants for clarity:
    • IXmlSerializableWriteMethodName = nameof(IXmlSerializable.Write) — used for the explicit interface method signature and the WriteObjectValue switch case invocation
    • WriteMethodName = "WriteXml" — used for the body expression that calls the private helper
  • XmlSerializableVisitorTests.cs + test data — updated assertions and expected output to reflect the new body expression (this.WriteXml(...))
  • Regenerated all test projects via eng/packages/http-client-csharp/eng/scripts/Generate.ps1

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

…ate test projects

Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>
Copilot AI changed the title [WIP] Update UnbrandedGeneratorVersion to 1.0.0-alpha.20260219.3 Update UnbrandedGeneratorVersion to 1.0.0-alpha.20260219.3 Feb 20, 2026
… WriteXml, regenerate test projects

Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>
…odName and WriteMethodName

Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>
@jorgerangel-msft jorgerangel-msft merged commit 19a9a77 into typespec/update-http-client-1.0.0-alpha.20260219.3 Feb 20, 2026
3 checks passed
@jorgerangel-msft jorgerangel-msft deleted the copilot/sub-pr-56357 branch February 20, 2026 17:33
jorgerangel-msft added a commit that referenced this pull request Feb 20, 2026
* Update UnbrandedGeneratorVersion to 1.0.0-alpha.20260219.3

* Update UnbrandedGeneratorVersion to 1.0.0-alpha.20260219.3 (#56363)

* Initial plan

* Update XmlSerializableVisitor to use WriteXml method name and regenerate test projects

Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>

* Revert IXmlSerializable.cs, update XmlSerializableVisitor for private WriteXml, regenerate test projects

Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>

* Rename constants in XmlSerializableVisitor: IXmlSerializableWriteMethodName and WriteMethodName

Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>

---------

Co-authored-by: Ubuntu <cloudtest@e0b7f29bc000000.tkkhlgj2u51eln3mcb0lygmbye.dx.internal.cloudapp.net>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants