Change import path for LoggingHandler to accommodate upstream breaking changes#45516
Change import path for LoggingHandler to accommodate upstream breaking changes#45516rads-1996 merged 18 commits intoAzure:mainfrom
LoggingHandler to accommodate upstream breaking changes#45516Conversation
6da3ac7 to
170f2de
Compare
LoggingHandler to accomodate upstream breaking changesLoggingHandler to accommodate upstream breaking changes
b57b1cc to
c421227
Compare
There was a problem hiding this comment.
Pull request overview
Updates azure-monitor-opentelemetry-exporter samples/docs to use the LoggingHandler implementation from opentelemetry-instrumentation-logging (since opentelemetry.sdk._logs.LoggingHandler is being deprecated), and bumps pinned OpenTelemetry API/SDK versions accordingly.
Changes:
- Bump
opentelemetry-apiandopentelemetry-sdkpins from1.39→1.40. - Update README + log samples to import
LoggingHandlerfromopentelemetry.instrumentation.logging.handler. - Add a changelog entry describing the import-path change.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/monitor/azure-monitor-opentelemetry-exporter/setup.py | Updates pinned OpenTelemetry API/SDK versions. |
| sdk/monitor/azure-monitor-opentelemetry-exporter/samples/logs/sample_properties.py | Switches LoggingHandler import to instrumentation package. |
| sdk/monitor/azure-monitor-opentelemetry-exporter/samples/logs/sample_log.py | Switches LoggingHandler import to instrumentation package. |
| sdk/monitor/azure-monitor-opentelemetry-exporter/samples/logs/sample_exception.py | Switches LoggingHandler import to instrumentation package. |
| sdk/monitor/azure-monitor-opentelemetry-exporter/samples/logs/sample_custom_event.py | Switches LoggingHandler import to instrumentation package. |
| sdk/monitor/azure-monitor-opentelemetry-exporter/samples/logs/sample_correlate.py | Switches LoggingHandler import to instrumentation package. |
| sdk/monitor/azure-monitor-opentelemetry-exporter/README.md | Updates code snippets to use new LoggingHandler import path. |
| sdk/monitor/azure-monitor-opentelemetry-exporter/CHANGELOG.md | Notes the import-path change for LoggingHandler. |
You can also share your feedback on Copilot code review. Take the survey.
sdk/monitor/azure-monitor-opentelemetry-exporter/samples/logs/sample_properties.py
Show resolved
Hide resolved
sdk/monitor/azure-monitor-opentelemetry-exporter/samples/logs/sample_log.py
Show resolved
Hide resolved
sdk/monitor/azure-monitor-opentelemetry-exporter/samples/logs/sample_exception.py
Show resolved
Hide resolved
sdk/monitor/azure-monitor-opentelemetry-exporter/samples/logs/sample_custom_event.py
Show resolved
Hide resolved
sdk/monitor/azure-monitor-opentelemetry-exporter/samples/logs/sample_correlate.py
Show resolved
Hide resolved
ec9bd0d to
b64b5f7
Compare
|
/check-enforcer override |
2 similar comments
|
/check-enforcer override |
|
/check-enforcer override |
46f9601 to
3000f72
Compare
|
/check-enforcer override |
|
/check-enforcer override |
1 similar comment
|
/check-enforcer override |
|
/check-enforcer override |
1 similar comment
|
/check-enforcer override |
|
/check-enforcer override |
|
/check-enforcer override |
2 similar comments
|
/check-enforcer override |
|
/check-enforcer override |
| "opentelemetry-api==1.39", | ||
| "opentelemetry-sdk==1.39", | ||
| "opentelemetry-api==1.40", | ||
| "opentelemetry-sdk==1.40", |
There was a problem hiding this comment.
This conflicts with the version in sdk/monitor/azure-monitor-opentelemetry
There was a problem hiding this comment.
I will update the versions in azure-monitor-opentelemetry after the exporter is released. azure-monitor-opentelemetry depends on the exporter, so the versions have to updated there first before making changes in azure-monitor-opentelemetry
There was a problem hiding this comment.
Can you update it now? It blocks the azure-core release.
There was a problem hiding this comment.
Can you update it now? It blocks the azure-core release.
I am trying to release the exporter. Until that is released, the distro changes will fail, even if I update them. Give me some time, I am working on releasing the exporter.
There was a problem hiding this comment.
@rads-1996 what is your alias? I'll reach out over teams. You can skip the failing check with a queue time build variable of Skip.AnalyzeDependencies with value of true to get your release out.
There was a problem hiding this comment.
Is there a commit I can use to release the exporter? If I use the https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6030525, it fails because of the dependency mismatch, I am using the skip.test=true and BuildTargetingString = azure-monitor-opentelemetry-exporter
There was a problem hiding this comment.
@xiangyan99 I have released the exporter and have another PR up for review which updates the otel versions in azure-monitor-opentelemetry - #45539. Once it is approved, I will merge the PR.
EDIT: The PR has been merged. This should unblock your release.
Description
LoggingHandler from
opentelemetry.sdk_logsis being deprecated. Need to use the LoggingHandler from theopentelemetry-instrumentation-logginginstead.All SDK Contribution checklist:
General Guidelines and Best Practices