Skip to content

Update test that use legacy WPJ API, Fixes AB#3528431#2483

Open
p3dr0rv wants to merge 11 commits intodevfrom
pedroro/remove-legacy-wpj-tests
Open

Update test that use legacy WPJ API, Fixes AB#3528431#2483
p3dr0rv wants to merge 11 commits intodevfrom
pedroro/remove-legacy-wpj-tests

Conversation

@p3dr0rv
Copy link
Collaborator

@p3dr0rv p3dr0rv commented Mar 17, 2026

This pull request removes several unused test classes and updates test logic for device registration and workplace join scenarios, particularly around migration and verification of device records. The changes focus on cleaning up redundant code and improving the accuracy and reliability of test assertions for device registration workflows.

AB#3528431

Related PR: 3021

validation: https://identitydivision.visualstudio.com/Engineering/_build/results?buildId=1608442&view=results

@github-actions
Copy link

❌ Work item link check failed. Description does not contain AB#{ID}.

Click here to Learn more.

@p3dr0rv p3dr0rv added the No-Changelog This change does not update the changelog. label Mar 17, 2026
@github-actions
Copy link

❌ Work item link check failed. Description contains AB#3528431 but the Bot could not link it to an Azure Boards work item.

Click here to learn more.

@github-actions github-actions bot changed the title WIP WIP, Fixes AB#3528431 Mar 17, 2026
@p3dr0rv p3dr0rv marked this pull request as ready for review March 18, 2026 19:57
@p3dr0rv p3dr0rv requested review from a team as code owners March 18, 2026 19:57
Copilot AI review requested due to automatic review settings March 18, 2026 19:57
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Cleans up Android broker automation tests by removing redundant/unreferenced test classes and adjusting assertions around MWPJ device registration/migration scenarios.

Changes:

  • Removed multiple MWPJ test case classes and broker update/custom-installation base classes.
  • Updated MWPJ test assertions to validate device registration records via multipleWpjApiFragment.allRecords.
  • Updated a few broker-host test calls to use newer/centralized broker APIs (e.g., wpjLeave(username), shared device registration).

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
msalautomationapp/src/androidTest/java/com/microsoft/identity/client/msal/automationapp/testpass/broker/mwpj/TestCase2579654.kt Changes post-unregister assertions and removes a legacy registration step.
msalautomationapp/src/androidTest/java/com/microsoft/identity/client/msal/automationapp/testpass/broker/mwpj/TestCase2563664.kt Deletes an MWPJ vs legacy visibility test case.
msalautomationapp/src/androidTest/java/com/microsoft/identity/client/msal/automationapp/testpass/broker/mwpj/TestCase2563653.kt Deletes an MWPJ join + legacy account retrieval test case.
msalautomationapp/src/androidTest/java/com/microsoft/identity/client/msal/automationapp/testpass/broker/mwpj/TestCase2521960.kt Deletes an entry-migration (same tenant, different UPN) test case.
msalautomationapp/src/androidTest/java/com/microsoft/identity/client/msal/automationapp/testpass/broker/mwpj/TestCase2521946.kt Updates migration assertions to rely on extended-space record comparisons.
msalautomationapp/src/androidTest/java/com/microsoft/identity/client/msal/automationapp/testpass/broker/mam/TestCase2516571.kt Updates wpjLeave to provide the username.
msalautomationapp/src/androidTest/java/com/microsoft/identity/client/msal/automationapp/testpass/broker/ltw/TestCase2582292.java Switches shared device registration call path.
msalautomationapp/src/androidTest/java/com/microsoft/identity/client/msal/automationapp/testpass/broker/AbstractMsalCustomBrokerInstallationTest.java Removes a custom broker installation base class.
msalautomationapp/src/androidTest/java/com/microsoft/identity/client/msal/automationapp/testpass/broker/AbstractMsalBrokerUpdateTest.java Removes a broker update test base class.
common Updates the common submodule commit pointer.
Comments suppressed due to low confidence (1)

common:1

  • This PR updates the common submodule commit, but the PR description focuses on test cleanup/logic changes and doesn't mention the dependency bump. Since submodule updates can have broad impact (and may be required for the test changes), consider explicitly calling out the common commit update and the reason (e.g., required API changes in test automation helpers) in the PR description.

@p3dr0rv p3dr0rv changed the title WIP, Fixes AB#3528431 Update test that use legacy WPJ API, Fixes AB#3528431 Mar 18, 2026
p3dr0rv and others added 4 commits March 18, 2026 17:53
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

No-Changelog This change does not update the changelog. test-automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants