Update test that use legacy WPJ API, Fixes AB#3528431#2483
Open
Update test that use legacy WPJ API, Fixes AB#3528431#2483
Conversation
|
❌ Work item link check failed. Description does not contain AB#{ID}. Click here to Learn more. |
|
❌ Work item link check failed. Description contains AB#3528431 but the Bot could not link it to an Azure Boards work item. Click here to learn more. |
Contributor
There was a problem hiding this comment.
Pull request overview
Cleans up Android broker automation tests by removing redundant/unreferenced test classes and adjusting assertions around MWPJ device registration/migration scenarios.
Changes:
- Removed multiple MWPJ test case classes and broker update/custom-installation base classes.
- Updated MWPJ test assertions to validate device registration records via
multipleWpjApiFragment.allRecords. - Updated a few broker-host test calls to use newer/centralized broker APIs (e.g.,
wpjLeave(username), shared device registration).
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| msalautomationapp/src/androidTest/java/com/microsoft/identity/client/msal/automationapp/testpass/broker/mwpj/TestCase2579654.kt | Changes post-unregister assertions and removes a legacy registration step. |
| msalautomationapp/src/androidTest/java/com/microsoft/identity/client/msal/automationapp/testpass/broker/mwpj/TestCase2563664.kt | Deletes an MWPJ vs legacy visibility test case. |
| msalautomationapp/src/androidTest/java/com/microsoft/identity/client/msal/automationapp/testpass/broker/mwpj/TestCase2563653.kt | Deletes an MWPJ join + legacy account retrieval test case. |
| msalautomationapp/src/androidTest/java/com/microsoft/identity/client/msal/automationapp/testpass/broker/mwpj/TestCase2521960.kt | Deletes an entry-migration (same tenant, different UPN) test case. |
| msalautomationapp/src/androidTest/java/com/microsoft/identity/client/msal/automationapp/testpass/broker/mwpj/TestCase2521946.kt | Updates migration assertions to rely on extended-space record comparisons. |
| msalautomationapp/src/androidTest/java/com/microsoft/identity/client/msal/automationapp/testpass/broker/mam/TestCase2516571.kt | Updates wpjLeave to provide the username. |
| msalautomationapp/src/androidTest/java/com/microsoft/identity/client/msal/automationapp/testpass/broker/ltw/TestCase2582292.java | Switches shared device registration call path. |
| msalautomationapp/src/androidTest/java/com/microsoft/identity/client/msal/automationapp/testpass/broker/AbstractMsalCustomBrokerInstallationTest.java | Removes a custom broker installation base class. |
| msalautomationapp/src/androidTest/java/com/microsoft/identity/client/msal/automationapp/testpass/broker/AbstractMsalBrokerUpdateTest.java | Removes a broker update test base class. |
| common | Updates the common submodule commit pointer. |
Comments suppressed due to low confidence (1)
common:1
- This PR updates the
commonsubmodule commit, but the PR description focuses on test cleanup/logic changes and doesn't mention the dependency bump. Since submodule updates can have broad impact (and may be required for the test changes), consider explicitly calling out thecommoncommit update and the reason (e.g., required API changes in test automation helpers) in the PR description.
...ava/com/microsoft/identity/client/msal/automationapp/testpass/broker/mwpj/TestCase2579654.kt
Outdated
Show resolved
Hide resolved
...ava/com/microsoft/identity/client/msal/automationapp/testpass/broker/mwpj/TestCase2521946.kt
Show resolved
Hide resolved
...va/com/microsoft/identity/client/msal/automationapp/testpass/broker/ltw/TestCase2582292.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request removes several unused test classes and updates test logic for device registration and workplace join scenarios, particularly around migration and verification of device records. The changes focus on cleaning up redundant code and improving the accuracy and reliability of test assertions for device registration workflows.
AB#3528431
Related PR: 3021
validation: https://identitydivision.visualstudio.com/Engineering/_build/results?buildId=1608442&view=results