Conversation
bgavrilMS
reviewed
Jul 18, 2025
src/client/Microsoft.Identity.Client.Extensions.Msal/Shared/StorageCreationPropertiesBuilder.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Jul 22, 2025
src/client/Microsoft.Identity.Client/ApiConfig/AcquireTokenForClientParameterBuilder.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Jul 22, 2025
bgavrilMS
reviewed
Jul 22, 2025
Member
bgavrilMS
left a comment
bgavrilMS
left a comment
There was a problem hiding this comment.
LGTM so far, some minor comments and TODOs are left
bgavrilMS
reviewed
Jul 29, 2025
src/client/Microsoft.Identity.Client/Extensibility/AcquireTokenForClientBuilderExtensions.cs
Show resolved
Hide resolved
bgavrilMS
approved these changes
Jul 29, 2025
src/client/Microsoft.Identity.Client/ApiConfig/Parameters/AcquireTokenCommonParameters.cs
Show resolved
Hide resolved
tests/Microsoft.Identity.Test.Unit/PublicApiTests/ExtraBodyParametersTests.cs
Outdated
Show resolved
Hide resolved
neha-bhargava
approved these changes
Aug 4, 2025
bgavrilMS
approved these changes
Aug 12, 2025
Member
|
This has been approved @trwalke . Merge it? |
# Conflicts: # src/client/Microsoft.Identity.Client/Extensibility/AbstractConfidentialClientAcquireTokenParameterBuilderExtension.cs # src/client/Microsoft.Identity.Client/PublicApi/net462/PublicAPI.Unshipped.txt # src/client/Microsoft.Identity.Client/PublicApi/net472/PublicAPI.Unshipped.txt # src/client/Microsoft.Identity.Client/PublicApi/net8.0-android/PublicAPI.Unshipped.txt # src/client/Microsoft.Identity.Client/PublicApi/net8.0-ios/PublicAPI.Unshipped.txt # src/client/Microsoft.Identity.Client/PublicApi/net8.0/PublicAPI.Unshipped.txt # src/client/Microsoft.Identity.Client/PublicApi/netstandard2.0/PublicAPI.Unshipped.txt
neha-bhargava
approved these changes
Aug 13, 2025
This was referenced Dec 8, 2025
Closed
This was referenced Dec 17, 2025
This was referenced Dec 29, 2025
Bump Microsoft.Identity.Client and Microsoft.IdentityModel.Abstractions
microsoft/Agents-for-net#569
Closed
Closed
This was referenced Jan 10, 2026
This was referenced Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Changes proposed in this request
This PR adds a new extensibility API
WithExtraBodyParameters(Dictionary<string, Func<CancellationToken, Task<string>>> extrabodyparams)The body params are in the form of
Dictionary<string, Func<CancellationToken, Task<string>>>because this will give developers an opportunity to provide a delegate to achieve the dictionary value because it is possible that it may change depending on when it is acquired.These parameters are added to the body parameters of the outgoing request and they are added to the cache key. This way, the tokens acquired with these parameters will only be retrieved when the same parameters are provided.
Testing
Unit/Manual
Documentation