Imdsv2: Generate CSR and execute CSR request#5427
Merged
Robbie-Microsoft merged 32 commits intorginsburg/msiv2_feature_branchfrom Aug 27, 2025
Merged
Imdsv2: Generate CSR and execute CSR request#5427Robbie-Microsoft merged 32 commits intorginsburg/msiv2_feature_branchfrom
Robbie-Microsoft merged 32 commits intorginsburg/msiv2_feature_branchfrom
Conversation
gladjohn
reviewed
Aug 6, 2025
src/client/Microsoft.Identity.Client/ManagedIdentity/CsrRequestResponse.cs
Outdated
Show resolved
Hide resolved
gladjohn
reviewed
Aug 6, 2025
src/client/Microsoft.Identity.Client/ManagedIdentity/ImdsV2ManagedIdentitySource.cs
Outdated
Show resolved
Hide resolved
gladjohn
reviewed
Aug 6, 2025
src/client/Microsoft.Identity.Client/ManagedIdentity/CsrRequest.cs
Outdated
Show resolved
Hide resolved
gladjohn
reviewed
Aug 6, 2025
src/client/Microsoft.Identity.Client/ManagedIdentity/CsrRequest.cs
Outdated
Show resolved
Hide resolved
gladjohn
reviewed
Aug 7, 2025
src/client/Microsoft.Identity.Client/ManagedIdentity/CsrRequest.cs
Outdated
Show resolved
Hide resolved
gladjohn
reviewed
Aug 9, 2025
src/client/Microsoft.Identity.Client/ManagedIdentity/CsrMetadata.cs
Outdated
Show resolved
Hide resolved
gladjohn
reviewed
Aug 9, 2025
src/client/Microsoft.Identity.Client/ManagedIdentity/ClientCredentialRequestResponse.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Aug 11, 2025
src/client/Microsoft.Identity.Client/ManagedIdentity/ClientCredentialRequestResponse.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Aug 11, 2025
src/client/Microsoft.Identity.Client/ManagedIdentity/ImdsV2ManagedIdentitySource.cs
Show resolved
Hide resolved
bgavrilMS
reviewed
Aug 25, 2025
src/client/Microsoft.Identity.Client/ManagedIdentity/V2/CertificateRequestResponse.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
approved these changes
Aug 25, 2025
gladjohn
reviewed
Aug 25, 2025
src/client/Microsoft.Identity.Client/ManagedIdentity/V2/ImdsV2ManagedIdentitySource.cs
Outdated
Show resolved
Hide resolved
src/client/Microsoft.Identity.Client/ManagedIdentity/V2/ImdsV2ManagedIdentitySource.cs
Show resolved
Hide resolved
src/client/Microsoft.Identity.Client/ManagedIdentity/V2/ImdsV2ManagedIdentitySource.cs
Outdated
Show resolved
Hide resolved
gladjohn
reviewed
Aug 25, 2025
src/client/Microsoft.Identity.Client/ManagedIdentity/ManagedIdentityClient.cs
Show resolved
Hide resolved
gladjohn
reviewed
Aug 25, 2025
src/client/Microsoft.Identity.Client/ManagedIdentity/V2/CertificateRequest.cs
Show resolved
Hide resolved
gladjohn
reviewed
Aug 25, 2025
gladjohn
reviewed
Aug 25, 2025
gladjohn
reviewed
Aug 25, 2025
src/client/Microsoft.Identity.Client/ManagedIdentity/V2/ImdsV2ManagedIdentitySource.cs
Outdated
Show resolved
Hide resolved
gladjohn
reviewed
Aug 25, 2025
src/client/Microsoft.Identity.Client/ManagedIdentity/V2/ImdsV2ManagedIdentitySource.cs
Outdated
Show resolved
Hide resolved
gladjohn
reviewed
Aug 25, 2025
src/client/Microsoft.Identity.Client/ManagedIdentity/V2/CsrMetadata.cs
Outdated
Show resolved
Hide resolved
bartonjs
reviewed
Aug 25, 2025
src/client/Microsoft.Identity.Client/ManagedIdentity/V2/CertificateRequest.cs
Show resolved
Hide resolved
gladjohn
reviewed
Aug 26, 2025
gladjohn
reviewed
Aug 27, 2025
src/client/Microsoft.Identity.Client/ManagedIdentity/V2/CertificateRequest.cs
Show resolved
Hide resolved
gladjohn
reviewed
Aug 27, 2025
gladjohn
reviewed
Aug 27, 2025
src/client/Microsoft.Identity.Client/ManagedIdentity/V2/CsrMetadata.cs
Outdated
Show resolved
Hide resolved
gladjohn
reviewed
Aug 27, 2025
Contributor
|
Looks good overall, @Robbie-Microsoft, just a few minor comments remaining. I also see that the PR is already approved, so feel free to address the open comments and proceed with merging. Adding the suggested .NET 8 CSR comparison test would also be valuable for extra confidence and long-term regression coverage. |
Robbie-Microsoft
merged commit 8c03bb3
into
rginsburg/msiv2_feature_branch
3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.NET native CSR generation via RSA and ASN.1 Encoding. Tested with net462, net472, net8.0, netstandard2.0