Add extensibility to update parameters for ROPC flow by neha-bhargava · Pull Request #3130 · AzureAD/microsoft-identity-web

neha-bhargava · 2024-11-05T21:26:11Z

Add extension method to update the parameters for ROPC flow

You've read the Contributor Guide and Code of Conduct.
You've included unit or integration tests for your change, where applicable.
You've included inline docs for your change, where applicable.
There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Summary of the changes (Less than 80 chars)

Description

Add extensibility to the ROPC flow to enable OnbeforeTokenRequest.

Fixes #3129

github-actions · 2024-11-05T21:42:40Z

Summary


Generated on:	11/5/2024 - 9:42:39 PM
Coverage date:	11/5/2024 - 9:42:35 PM
Parser:	Cobertura
Assemblies:	9
Classes:	158
Files:	166
Line coverage:	51% (3180 of 6230)
Covered lines:	3180
Uncovered lines:	3050
Coverable lines:	6230
Total lines:	19938
Branch coverage:	48% (1139 of 2368)
Covered branches:	1139
Total branches:	2368
Method coverage:	Feature is only available for sponsors

Coverage

Microsoft.Identity.Web - 63.4%

Name	Line	Branch
Microsoft.Identity.Web	63.4%	56.9%
Microsoft.Identity.Web.AadIssuerValidatorOptions	100%
Microsoft.Identity.Web.AccountExtensions	100%	100%
Microsoft.Identity.Web.AppContextSwitches	100%	100%
Microsoft.Identity.Web.AppServicesAuthenticationBuilderExtensions	100%
Microsoft.Identity.Web.AppServicesAuthenticationHandler	0%	0%
Microsoft.Identity.Web.AppServicesAuthenticationInformation	78.8%	59%
Microsoft.Identity.Web.AppServicesAuthenticationTokenAcquisition	0%	0%
Microsoft.Identity.Web.AuthorityHelpers	100%	92.3%
Microsoft.Identity.Web.AuthorizeForScopesAttribute	8.3%	7.1%
Microsoft.Identity.Web.AzureADB2COpenIDConnectEventHandlers	97.5%	87.5%
Microsoft.Identity.Web.AzureFunctionsAuthenticationHttpContextExtension	0%	0%
Microsoft.Identity.Web.ClaimsPrincipalFactory	81.2%	100%
Microsoft.Identity.Web.CookiePolicyOptionsExtensions	95.8%	90%
Microsoft.Identity.Web.DefaultMicrosoftIdentityAuthenticationDelegatingHand lerFactory	100%
Microsoft.Identity.Web.DownstreamWebApi	10.8%	0%
Microsoft.Identity.Web.DownstreamWebApiExtensions	100%
Microsoft.Identity.Web.DownstreamWebApiGenericExtensions	0%	0%
Microsoft.Identity.Web.DownstreamWebApiOptions	94.7%	50%
Microsoft.Identity.Web.Extensions	100%	100%
Microsoft.Identity.Web.IDownstreamWebApi	0%
Microsoft.Identity.Web.IncrementalConsentAndConditionalAccessHelper	95.8%	87.5%
Microsoft.Identity.Web.MergedOptionsValidation	100%	100%
Microsoft.Identity.Web.MicrosoftIdentityAppAuthenticationMessageHandler	100%	100%
Microsoft.Identity.Web.MicrosoftIdentityAppCallsWebApiAuthenticationBuilder Extension	0%	0%
Microsoft.Identity.Web.MicrosoftIdentityAuthenticationBaseMessageHandler	96%	62.5%
Microsoft.Identity.Web.MicrosoftIdentityAuthenticationBaseOptions	100%	50%
Microsoft.Identity.Web.MicrosoftIdentityAuthenticationMessageHandlerHttpCli entBuilderExtensions	91.3%
Microsoft.Identity.Web.MicrosoftIdentityAuthenticationMessageHandlerOptions	90%
Microsoft.Identity.Web.MicrosoftIdentityBlazorServiceCollectionExtensions	100%
Microsoft.Identity.Web.MicrosoftIdentityConsentAndConditionalAccessHandler	4.9%	0%
Microsoft.Identity.Web.MicrosoftIdentityServiceHandler	0%
Microsoft.Identity.Web.MicrosoftIdentityUserAuthenticationMessageHandler	100%	66.6%
Microsoft.Identity.Web.MicrosoftIdentityWebApiAuthenticationBuilder	78.9%	0%
Microsoft.Identity.Web.MicrosoftIdentityWebApiAuthenticationBuilderExtensio ns	62.2%	27.7%
Microsoft.Identity.Web.MicrosoftIdentityWebApiAuthenticationBuilderWithConf iguration	100%
Microsoft.Identity.Web.MicrosoftIdentityWebApiServiceCollectionExtensions	0%
Microsoft.Identity.Web.MicrosoftIdentityWebAppAuthenticationBuilder	94.6%	83.3%
Microsoft.Identity.Web.MicrosoftIdentityWebAppAuthenticationBuilderExtensio ns	97%	88.7%
Microsoft.Identity.Web.MicrosoftIdentityWebAppAuthenticationBuilderWithConf iguration	81.2%
Microsoft.Identity.Web.MicrosoftIdentityWebAppServiceCollectionExtensions	100%
Microsoft.Identity.Web.PolicyBuilderExtensions	100%
Microsoft.Identity.Web.RequiredScopeExtensions	40%
Microsoft.Identity.Web.RequiredScopeOrAppPermissionExtensions	33.3%
Microsoft.Identity.Web.RequireScopeOptions	100%	50%
Microsoft.Identity.Web.RequireScopeOrAppPermissionOptions	100%	50%
Microsoft.Identity.Web.Resource.JwtBearerMiddlewareDiagnostics	100%	100%
Microsoft.Identity.Web.Resource.MicrosoftIdentityIssuerValidatorFactory	90%	62.5%
Microsoft.Identity.Web.Resource.OpenIdConnectMiddlewareDiagnostics	100%	83.3%
Microsoft.Identity.Web.Resource.RegisterValidAudience	95.6%	90%
Microsoft.Identity.Web.Resource.RequiredScopeAttribute	0%
Microsoft.Identity.Web.Resource.RequiredScopeOrAppPermissionAttribute	0%
Microsoft.Identity.Web.Resource.RolesRequiredHttpContextExtensions	100%	100%
Microsoft.Identity.Web.Resource.ScopesRequiredHttpContextExtensions	100%	100%
Microsoft.Identity.Web.ScopeAuthorizationHandler	90.3%	73%
Microsoft.Identity.Web.ScopeAuthorizationRequirement	100%	50%
Microsoft.Identity.Web.ScopeOrAppPermissionAuthorizationHandler	90.2%	72.9%
Microsoft.Identity.Web.ScopeOrAppPermissionAuthorizationRequirement	78.9%	60%
Microsoft.Identity.Web.TempDataLoginErrorAccessor	15%	25%
Microsoft.Identity.Web.TokenAcquisitionAppTokenCredential	0%
Microsoft.Identity.Web.TokenAcquisitionTokenCredential	0%
Microsoft.Identity.Web.TokenCacheProviders.Session.MsalSessionTokenCachePro vider	0%	0%
Microsoft.Identity.Web.TokenCacheProviders.Session.SessionTokenCacheProvide rExtension	0%	0%

Microsoft.Identity.Web.Certificate - 41.4%

Name	Line	Branch
Microsoft.Identity.Web.Certificate	41.4%	26.5%
Microsoft.Identity.Web.Base64EncodedCertificateLoader	90.9%	66.6%
Microsoft.Identity.Web.CertificateDescription	87.9%
Microsoft.Identity.Web.CertificateLoaderHelper	29.1%	20%
Microsoft.Identity.Web.DefaultCertificateLoader	45.6%	31.8%
Microsoft.Identity.Web.DefaultCredentialsLoader	54.7%	50%
Microsoft.Identity.Web.FromPathCertificateLoader	0%
Microsoft.Identity.Web.KeyVaultCertificateLoader	0%	0%
Microsoft.Identity.Web.SignedAssertionFilePathCredentialsLoader	93.7%	100%
Microsoft.Identity.Web.SignedAssertionFromManagedIdentityCredentialLoader	15.7%	0%
Microsoft.Identity.Web.StoreWithDistinguishedNameCertificateLoader	0%
Microsoft.Identity.Web.StoreWithThumbprintCertificateLoader	0%

Microsoft.Identity.Web.Certificateless - 40.1%

Name	Line	Branch
Microsoft.Identity.Web.Certificateless	40.1%	43.2%
Microsoft.Identity.Web.AzureIdentityForKubernetesClientAssertion	58.1%	63.1%
Microsoft.Identity.Web.CertificatelessOptions	100%
Microsoft.Identity.Web.ClientAssertion	100%
Microsoft.Identity.Web.ClientAssertionProviderBase	100%	80%
Microsoft.Identity.Web.ManagedIdentityClientAssertion	0%	0%

Microsoft.Identity.Web.Diagnostics - 10.2%

Name	Line	Branch
Microsoft.Identity.Web.Diagnostics	10.2%	7.1%
Microsoft.Identity.Web.Diagnostics.OsHelper	33.3%
Microsoft.Identity.Web.Throws	8.6%	7.1%

Microsoft.Identity.Web.DownstreamApi - 14.5%

Name	Line	Branch
Microsoft.Identity.Web.DownstreamApi	14.5%	16.1%
Microsoft.Extensions.Configuration.Binder.SourceGeneration	0%	0%
Microsoft.Identity.Web.DownstreamApi	15.4%	21.6%
Microsoft.Identity.Web.DownstreamApiExtensions	51.4%	80%
Microsoft.Identity.Web.DownstreamApiLoggingEventId	100%
System.Runtime.CompilerServices	0%

Microsoft.Identity.Web.MicrosoftGraph - 42%

Name	Line	Branch
Microsoft.Identity.Web.MicrosoftGraph	42%	4.5%
Microsoft.Identity.Web.BaseRequestExtensions	0%	0%
Microsoft.Identity.Web.GraphServiceCollectionExtensions	82.7%	50%
Microsoft.Identity.Web.MicrosoftGraphExtensions	67.7%
Microsoft.Identity.Web.MicrosoftGraphOptions	100%
Microsoft.Identity.Web.TokenAcquisitionAuthenticationProvider	13.5%	0%
Microsoft.Identity.Web.TokenAcquisitionAuthenticationProviderOption	16.6%

Microsoft.Identity.Web.Test.Common - 69.3%

Name	Line	Branch
Microsoft.Identity.Web.Test.Common	69.3%	64.5%
Microsoft.Identity.Web.Test.Common.Asserts	100%
Microsoft.Identity.Web.Test.Common.Mocks.LoggerMock`1	50%	100%
Microsoft.Identity.Web.Test.Common.Mocks.MockHttpClientFactory	100%	33.3%
Microsoft.Identity.Web.Test.Common.Mocks.MockHttpContextAccessor	100%
Microsoft.Identity.Web.Test.Common.Mocks.MockHttpCreator	60.8%
Microsoft.Identity.Web.Test.Common.Mocks.MockHttpMessageHandler	76.4%	75%
Microsoft.Identity.Web.Test.Common.Mocks.QueryStringParser	86.8%	85.7%
Microsoft.Identity.Web.Test.Common.Mocks.QueueHttpMessageHandler	57.1%	37.5%
Microsoft.Identity.Web.Test.Common.TestConstants	100%
Microsoft.Identity.Web.Test.Common.TestHelpers.ExternalApp	0%	0%
Microsoft.Identity.Web.Test.Common.TestHelpers.HttpContextUtilities	100%
Microsoft.Identity.Web.Test.Common.TestHelpers.InMemoryTokenCache	0%	0%
Microsoft.Identity.Web.Test.Common.TestHelpers.MsalTestTokenCacheProvider	26.6%
Microsoft.Identity.Web.Test.Common.TestHelpers.TestMsalDistributedTokenCach eAdapter	100%
Microsoft.Identity.Web.Test.Common.TestHelpers.TestOptionsMonitor`1	50%	0%

Microsoft.Identity.Web.TokenAcquisition - 52%

Name	Line	Branch
Microsoft.Identity.Web.TokenAcquisition	52%	54.2%
Microsoft.Identity.Web.ApplicationBuilderExtensions	0%
Microsoft.Identity.Web.AuthCodeRedemptionParameters	100%
Microsoft.Identity.Web.CiamAuthorityHelper	100%	92.8%
Microsoft.Identity.Web.ClientInfo	100%	87.5%
Microsoft.Identity.Web.ConfidentialClientApplicationBuilderExtension	79%	60.5%
Microsoft.Identity.Web.ConfidentialClientApplicationOptionsMerger	100%	50%
Microsoft.Identity.Web.DefaultAuthorizationHeaderProvider	54.9%	26.6%
Microsoft.Identity.Web.DefaultTokenAcquirerFactoryImplementation	1.6%	0%
Microsoft.Identity.Web.Experimental.CertificateChangeEventArg	0%
Microsoft.Identity.Web.Extensibility.BaseAuthorizationHeaderProvider	45.4%
Microsoft.Identity.Web.Hosts.DefaultTokenAcquisitionHost	38.4%	0%
Microsoft.Identity.Web.HttpContextExtensions	100%
Microsoft.Identity.Web.IdHelper	95.8%	50%
Microsoft.Identity.Web.Internal.WebApiBuilders	100%	100%
Microsoft.Identity.Web.ITokenAcquisition	0%
Microsoft.Identity.Web.JwtBearerOptionsMerger	0%	0%
Microsoft.Identity.Web.LoggingEventId	100%
Microsoft.Identity.Web.LoggingOptions	100%
Microsoft.Identity.Web.MergedOptions	93.3%	92%
Microsoft.Identity.Web.MergedOptionsStore	100%
Microsoft.Identity.Web.MicrosoftIdentityAppCallsWebApiAuthenticationBuilder	83.3%	100%
Microsoft.Identity.Web.MicrosoftIdentityApplicationOptionsMerger	60%	0%
Microsoft.Identity.Web.MicrosoftIdentityBaseAuthenticationBuilder	85.1%	78.5%
Microsoft.Identity.Web.MicrosoftIdentityOptions	100%	75%
Microsoft.Identity.Web.MicrosoftIdentityOptionsMerger	100%	50%
Microsoft.Identity.Web.MicrosoftIdentityWebChallengeUserException	0%
Microsoft.Identity.Web.MsalAspNetCoreHttpClientFactory	50%
Microsoft.Identity.Web.MsAuth10AtPop	100%	100%
Microsoft.Identity.Web.PrincipalExtensionsForSecurityTokens	100%	70%
Microsoft.Identity.Web.ServiceCollectionExtensions	66.6%	64.2%
Microsoft.Identity.Web.TokenAcquirer	0%	0%
Microsoft.Identity.Web.TokenAcquirerFactory	55.4%	50%
Microsoft.Identity.Web.TokenAcquisition	21.3%	16%
Microsoft.Identity.Web.TokenAcquisitionAspNetCore	4.6%	0%
Microsoft.Identity.Web.TokenAcquisitionAspnetCoreHost	40.4%	23.6%
Microsoft.Identity.Web.TokenAcquisitionExtensionOptions	100%	100%
Microsoft.Identity.Web.TokenAcquisitionOptions	100%
Microsoft.Identity.Web.Util.Base64UrlHelpers	93.4%	81.4%

Microsoft.Identity.Web.TokenCache - 80.8%

Name	Line	Branch
Microsoft.Identity.Web.TokenCache	80.8%	82.6%
Microsoft.Identity.Web.ClaimsPrincipalExtensions	96.7%	100%
Microsoft.Identity.Web.LoggingEventId	100%
Microsoft.Identity.Web.TokenCacheExtensions	100%
Microsoft.Identity.Web.TokenCacheProviders.CacheSerializerHints	100%
Microsoft.Identity.Web.TokenCacheProviders.Distributed.DistributedTokenCach eAdapterExtension	100%
Microsoft.Identity.Web.TokenCacheProviders.Distributed.MsalDistributedToken CacheAdapter	83%	83.3%
Microsoft.Identity.Web.TokenCacheProviders.Distributed.MsalDistributedToken CacheAdapterOptions	88.8%
Microsoft.Identity.Web.TokenCacheProviders.InMemory.InMemoryTokenCacheProvi derExtension	100%
Microsoft.Identity.Web.TokenCacheProviders.InMemory.MsalMemoryTokenCacheOpt ions	100%
Microsoft.Identity.Web.TokenCacheProviders.InMemory.MsalMemoryTokenCachePro vider	83.8%	81.8%
Microsoft.Identity.Web.TokenCacheProviders.MeasureDurationResult	100%
Microsoft.Identity.Web.TokenCacheProviders.MeasureDurationResult`1	0%
Microsoft.Identity.Web.TokenCacheProviders.MsalAbstractTokenCacheProvider	50.7%	66.6%
Microsoft.Identity.Web.TokenCacheProviders.Utility	54.5%

jmprieur

LGTM for the product changers
Not sure about the test

I think your branch is not up to date with master?

src/Microsoft.Identity.Web.TokenAcquisition/TokenAcquisitionExtensionOptions.cs

tests/Microsoft.Identity.Web.Test/TokenAcquisitionAddInTests.cs

neha-bhargava · 2024-11-06T00:53:21Z

LGTM for the product changers Not sure about the test

I think your branch is not up to date with master?

Updated the test to validate the params sent in the request as changed through extensibility. I don't see updates from master

src/Microsoft.Identity.Web.TokenAcquisition/TokenAcquisition.cs

github-actions · 2024-11-07T00:17:55Z

Summary


Generated on:	11/7/2024 - 12:17:53 AM
Coverage date:	11/7/2024 - 12:17:51 AM
Parser:	Cobertura
Assemblies:	9
Classes:	158
Files:	166
Line coverage:	51.1% (3193 of 6243)
Covered lines:	3193
Uncovered lines:	3050
Coverable lines:	6243
Total lines:	19969
Branch coverage:	48.1% (1143 of 2372)
Covered branches:	1143
Total branches:	2372
Method coverage:	Feature is only available for sponsors

Coverage

Microsoft.Identity.Web - 63.4%

Name	Line	Branch
Microsoft.Identity.Web	63.4%	56.9%
Microsoft.Identity.Web.AadIssuerValidatorOptions	100%
Microsoft.Identity.Web.AccountExtensions	100%	100%
Microsoft.Identity.Web.AppContextSwitches	100%	100%
Microsoft.Identity.Web.AppServicesAuthenticationBuilderExtensions	100%
Microsoft.Identity.Web.AppServicesAuthenticationHandler	0%	0%
Microsoft.Identity.Web.AppServicesAuthenticationInformation	78.8%	59%
Microsoft.Identity.Web.AppServicesAuthenticationTokenAcquisition	0%	0%
Microsoft.Identity.Web.AuthorityHelpers	100%	92.3%
Microsoft.Identity.Web.AuthorizeForScopesAttribute	8.3%	7.1%
Microsoft.Identity.Web.AzureADB2COpenIDConnectEventHandlers	97.5%	87.5%
Microsoft.Identity.Web.AzureFunctionsAuthenticationHttpContextExtension	0%	0%
Microsoft.Identity.Web.ClaimsPrincipalFactory	81.2%	100%
Microsoft.Identity.Web.CookiePolicyOptionsExtensions	95.8%	90%
Microsoft.Identity.Web.DefaultMicrosoftIdentityAuthenticationDelegatingHand lerFactory	100%
Microsoft.Identity.Web.DownstreamWebApi	10.8%	0%
Microsoft.Identity.Web.DownstreamWebApiExtensions	100%
Microsoft.Identity.Web.DownstreamWebApiGenericExtensions	0%	0%
Microsoft.Identity.Web.DownstreamWebApiOptions	94.7%	50%
Microsoft.Identity.Web.Extensions	100%	100%
Microsoft.Identity.Web.IDownstreamWebApi	0%
Microsoft.Identity.Web.IncrementalConsentAndConditionalAccessHelper	95.8%	87.5%
Microsoft.Identity.Web.MergedOptionsValidation	100%	100%
Microsoft.Identity.Web.MicrosoftIdentityAppAuthenticationMessageHandler	100%	100%
Microsoft.Identity.Web.MicrosoftIdentityAppCallsWebApiAuthenticationBuilder Extension	0%	0%
Microsoft.Identity.Web.MicrosoftIdentityAuthenticationBaseMessageHandler	96%	62.5%
Microsoft.Identity.Web.MicrosoftIdentityAuthenticationBaseOptions	100%	50%
Microsoft.Identity.Web.MicrosoftIdentityAuthenticationMessageHandlerHttpCli entBuilderExtensions	91.3%
Microsoft.Identity.Web.MicrosoftIdentityAuthenticationMessageHandlerOptions	90%
Microsoft.Identity.Web.MicrosoftIdentityBlazorServiceCollectionExtensions	100%
Microsoft.Identity.Web.MicrosoftIdentityConsentAndConditionalAccessHandler	4.9%	0%
Microsoft.Identity.Web.MicrosoftIdentityServiceHandler	0%
Microsoft.Identity.Web.MicrosoftIdentityUserAuthenticationMessageHandler	100%	66.6%
Microsoft.Identity.Web.MicrosoftIdentityWebApiAuthenticationBuilder	78.9%	0%
Microsoft.Identity.Web.MicrosoftIdentityWebApiAuthenticationBuilderExtensio ns	62.2%	27.7%
Microsoft.Identity.Web.MicrosoftIdentityWebApiAuthenticationBuilderWithConf iguration	100%
Microsoft.Identity.Web.MicrosoftIdentityWebApiServiceCollectionExtensions	0%
Microsoft.Identity.Web.MicrosoftIdentityWebAppAuthenticationBuilder	94.6%	83.3%
Microsoft.Identity.Web.MicrosoftIdentityWebAppAuthenticationBuilderExtensio ns	97%	88.7%
Microsoft.Identity.Web.MicrosoftIdentityWebAppAuthenticationBuilderWithConf iguration	81.2%
Microsoft.Identity.Web.MicrosoftIdentityWebAppServiceCollectionExtensions	100%
Microsoft.Identity.Web.PolicyBuilderExtensions	100%
Microsoft.Identity.Web.RequiredScopeExtensions	40%
Microsoft.Identity.Web.RequiredScopeOrAppPermissionExtensions	33.3%
Microsoft.Identity.Web.RequireScopeOptions	100%	50%
Microsoft.Identity.Web.RequireScopeOrAppPermissionOptions	100%	50%
Microsoft.Identity.Web.Resource.JwtBearerMiddlewareDiagnostics	100%	100%
Microsoft.Identity.Web.Resource.MicrosoftIdentityIssuerValidatorFactory	90%	62.5%
Microsoft.Identity.Web.Resource.OpenIdConnectMiddlewareDiagnostics	100%	83.3%
Microsoft.Identity.Web.Resource.RegisterValidAudience	95.6%	90%
Microsoft.Identity.Web.Resource.RequiredScopeAttribute	0%
Microsoft.Identity.Web.Resource.RequiredScopeOrAppPermissionAttribute	0%
Microsoft.Identity.Web.Resource.RolesRequiredHttpContextExtensions	100%	100%
Microsoft.Identity.Web.Resource.ScopesRequiredHttpContextExtensions	100%	100%
Microsoft.Identity.Web.ScopeAuthorizationHandler	90.3%	73%
Microsoft.Identity.Web.ScopeAuthorizationRequirement	100%	50%
Microsoft.Identity.Web.ScopeOrAppPermissionAuthorizationHandler	90.2%	72.9%
Microsoft.Identity.Web.ScopeOrAppPermissionAuthorizationRequirement	78.9%	60%
Microsoft.Identity.Web.TempDataLoginErrorAccessor	15%	25%
Microsoft.Identity.Web.TokenAcquisitionAppTokenCredential	0%
Microsoft.Identity.Web.TokenAcquisitionTokenCredential	0%
Microsoft.Identity.Web.TokenCacheProviders.Session.MsalSessionTokenCachePro vider	0%	0%
Microsoft.Identity.Web.TokenCacheProviders.Session.SessionTokenCacheProvide rExtension	0%	0%

Microsoft.Identity.Web.Certificate - 41.4%

Name	Line	Branch
Microsoft.Identity.Web.Certificate	41.4%	26.5%
Microsoft.Identity.Web.Base64EncodedCertificateLoader	90.9%	66.6%
Microsoft.Identity.Web.CertificateDescription	87.9%
Microsoft.Identity.Web.CertificateLoaderHelper	29.1%	20%
Microsoft.Identity.Web.DefaultCertificateLoader	45.6%	31.8%
Microsoft.Identity.Web.DefaultCredentialsLoader	54.7%	50%
Microsoft.Identity.Web.FromPathCertificateLoader	0%
Microsoft.Identity.Web.KeyVaultCertificateLoader	0%	0%
Microsoft.Identity.Web.SignedAssertionFilePathCredentialsLoader	93.7%	100%
Microsoft.Identity.Web.SignedAssertionFromManagedIdentityCredentialLoader	15.7%	0%
Microsoft.Identity.Web.StoreWithDistinguishedNameCertificateLoader	0%
Microsoft.Identity.Web.StoreWithThumbprintCertificateLoader	0%

Microsoft.Identity.Web.Certificateless - 40.1%

Name	Line	Branch
Microsoft.Identity.Web.Certificateless	40.1%	43.2%
Microsoft.Identity.Web.AzureIdentityForKubernetesClientAssertion	58.1%	63.1%
Microsoft.Identity.Web.CertificatelessOptions	100%
Microsoft.Identity.Web.ClientAssertion	100%
Microsoft.Identity.Web.ClientAssertionProviderBase	100%	80%
Microsoft.Identity.Web.ManagedIdentityClientAssertion	0%	0%

Microsoft.Identity.Web.Diagnostics - 10.2%

Name	Line	Branch
Microsoft.Identity.Web.Diagnostics	10.2%	7.1%
Microsoft.Identity.Web.Diagnostics.OsHelper	33.3%
Microsoft.Identity.Web.Throws	8.6%	7.1%

Microsoft.Identity.Web.DownstreamApi - 14.5%

Name	Line	Branch
Microsoft.Identity.Web.DownstreamApi	14.5%	16.1%
Microsoft.Extensions.Configuration.Binder.SourceGeneration	0%	0%
Microsoft.Identity.Web.DownstreamApi	15.4%	21.6%
Microsoft.Identity.Web.DownstreamApiExtensions	51.4%	80%
Microsoft.Identity.Web.DownstreamApiLoggingEventId	100%
System.Runtime.CompilerServices	0%

Microsoft.Identity.Web.MicrosoftGraph - 42%

Name	Line	Branch
Microsoft.Identity.Web.MicrosoftGraph	42%	4.5%
Microsoft.Identity.Web.BaseRequestExtensions	0%	0%
Microsoft.Identity.Web.GraphServiceCollectionExtensions	82.7%	50%
Microsoft.Identity.Web.MicrosoftGraphExtensions	67.7%
Microsoft.Identity.Web.MicrosoftGraphOptions	100%
Microsoft.Identity.Web.TokenAcquisitionAuthenticationProvider	13.5%	0%
Microsoft.Identity.Web.TokenAcquisitionAuthenticationProviderOption	16.6%

Microsoft.Identity.Web.Test.Common - 70.9%

Name	Line	Branch
Microsoft.Identity.Web.Test.Common	70.9%	66.6%
Microsoft.Identity.Web.Test.Common.Asserts	100%
Microsoft.Identity.Web.Test.Common.Mocks.LoggerMock`1	50%	100%
Microsoft.Identity.Web.Test.Common.Mocks.MockHttpClientFactory	100%	33.3%
Microsoft.Identity.Web.Test.Common.Mocks.MockHttpContextAccessor	100%
Microsoft.Identity.Web.Test.Common.Mocks.MockHttpCreator	68.9%
Microsoft.Identity.Web.Test.Common.Mocks.MockHttpMessageHandler	80.4%	81.2%
Microsoft.Identity.Web.Test.Common.Mocks.QueryStringParser	86.8%	85.7%
Microsoft.Identity.Web.Test.Common.Mocks.QueueHttpMessageHandler	57.1%	37.5%
Microsoft.Identity.Web.Test.Common.TestConstants	100%
Microsoft.Identity.Web.Test.Common.TestHelpers.ExternalApp	0%	0%
Microsoft.Identity.Web.Test.Common.TestHelpers.HttpContextUtilities	100%
Microsoft.Identity.Web.Test.Common.TestHelpers.InMemoryTokenCache	0%	0%
Microsoft.Identity.Web.Test.Common.TestHelpers.MsalTestTokenCacheProvider	26.6%
Microsoft.Identity.Web.Test.Common.TestHelpers.TestMsalDistributedTokenCach eAdapter	100%
Microsoft.Identity.Web.Test.Common.TestHelpers.TestOptionsMonitor`1	50%	0%

Microsoft.Identity.Web.TokenAcquisition - 52%

Name	Line	Branch
Microsoft.Identity.Web.TokenAcquisition	52%	54.2%
Microsoft.Identity.Web.ApplicationBuilderExtensions	0%
Microsoft.Identity.Web.AuthCodeRedemptionParameters	100%
Microsoft.Identity.Web.CiamAuthorityHelper	100%	92.8%
Microsoft.Identity.Web.ClientInfo	100%	87.5%
Microsoft.Identity.Web.ConfidentialClientApplicationBuilderExtension	79%	60.5%
Microsoft.Identity.Web.ConfidentialClientApplicationOptionsMerger	100%	50%
Microsoft.Identity.Web.DefaultAuthorizationHeaderProvider	54.9%	26.6%
Microsoft.Identity.Web.DefaultTokenAcquirerFactoryImplementation	1.6%	0%
Microsoft.Identity.Web.Experimental.CertificateChangeEventArg	0%
Microsoft.Identity.Web.Extensibility.BaseAuthorizationHeaderProvider	45.4%
Microsoft.Identity.Web.Hosts.DefaultTokenAcquisitionHost	38.4%	0%
Microsoft.Identity.Web.HttpContextExtensions	100%
Microsoft.Identity.Web.IdHelper	95.8%	50%
Microsoft.Identity.Web.Internal.WebApiBuilders	100%	100%
Microsoft.Identity.Web.ITokenAcquisition	0%
Microsoft.Identity.Web.JwtBearerOptionsMerger	0%	0%
Microsoft.Identity.Web.LoggingEventId	100%
Microsoft.Identity.Web.LoggingOptions	100%
Microsoft.Identity.Web.MergedOptions	93.3%	92%
Microsoft.Identity.Web.MergedOptionsStore	100%
Microsoft.Identity.Web.MicrosoftIdentityAppCallsWebApiAuthenticationBuilder	83.3%	100%
Microsoft.Identity.Web.MicrosoftIdentityApplicationOptionsMerger	60%	0%
Microsoft.Identity.Web.MicrosoftIdentityBaseAuthenticationBuilder	85.1%	78.5%
Microsoft.Identity.Web.MicrosoftIdentityOptions	100%	75%
Microsoft.Identity.Web.MicrosoftIdentityOptionsMerger	100%	50%
Microsoft.Identity.Web.MicrosoftIdentityWebChallengeUserException	0%
Microsoft.Identity.Web.MsalAspNetCoreHttpClientFactory	50%
Microsoft.Identity.Web.MsAuth10AtPop	100%	100%
Microsoft.Identity.Web.PrincipalExtensionsForSecurityTokens	100%	70%
Microsoft.Identity.Web.ServiceCollectionExtensions	66.6%	64.2%
Microsoft.Identity.Web.TokenAcquirer	0%	0%
Microsoft.Identity.Web.TokenAcquirerFactory	55.4%	50%
Microsoft.Identity.Web.TokenAcquisition	21.3%	16%
Microsoft.Identity.Web.TokenAcquisitionAspNetCore	4.6%	0%
Microsoft.Identity.Web.TokenAcquisitionAspnetCoreHost	40.4%	23.6%
Microsoft.Identity.Web.TokenAcquisitionExtensionOptions	100%	100%
Microsoft.Identity.Web.TokenAcquisitionOptions	100%
Microsoft.Identity.Web.Util.Base64UrlHelpers	93.4%	81.4%

Microsoft.Identity.Web.TokenCache - 80.8%

Name	Line	Branch
Microsoft.Identity.Web.TokenCache	80.8%	82.6%
Microsoft.Identity.Web.ClaimsPrincipalExtensions	96.7%	100%
Microsoft.Identity.Web.LoggingEventId	100%
Microsoft.Identity.Web.TokenCacheExtensions	100%
Microsoft.Identity.Web.TokenCacheProviders.CacheSerializerHints	100%
Microsoft.Identity.Web.TokenCacheProviders.Distributed.DistributedTokenCach eAdapterExtension	100%
Microsoft.Identity.Web.TokenCacheProviders.Distributed.MsalDistributedToken CacheAdapter	83%	83.3%
Microsoft.Identity.Web.TokenCacheProviders.Distributed.MsalDistributedToken CacheAdapterOptions	88.8%
Microsoft.Identity.Web.TokenCacheProviders.InMemory.InMemoryTokenCacheProvi derExtension	100%
Microsoft.Identity.Web.TokenCacheProviders.InMemory.MsalMemoryTokenCacheOpt ions	100%
Microsoft.Identity.Web.TokenCacheProviders.InMemory.MsalMemoryTokenCachePro vider	83.8%	81.8%
Microsoft.Identity.Web.TokenCacheProviders.MeasureDurationResult	100%
Microsoft.Identity.Web.TokenCacheProviders.MeasureDurationResult`1	0%
Microsoft.Identity.Web.TokenCacheProviders.MsalAbstractTokenCacheProvider	50.7%	66.6%
Microsoft.Identity.Web.TokenCacheProviders.Utility	54.5%

jennyf19

Need more time to think this through. ETA is 11/8 eod.

tests/Microsoft.Identity.Web.Test/TokenAcquisitionAddInTests.cs

github-actions · 2024-11-08T18:27:52Z

Summary


Generated on:	11/8/2024 - 6:27:50 PM
Coverage date:	11/8/2024 - 6:27:48 PM
Parser:	Cobertura
Assemblies:	9
Classes:	158
Files:	166
Line coverage:	51.2% (3202 of 6249)
Covered lines:	3202
Uncovered lines:	3047
Coverable lines:	6249
Total lines:	19990
Branch coverage:	48.5% (1155 of 2378)
Covered branches:	1155
Total branches:	2378
Method coverage:	Feature is only available for sponsors

Coverage

Microsoft.Identity.Web - 63.4%

Name	Line	Branch
Microsoft.Identity.Web	63.4%	56.9%
Microsoft.Identity.Web.AadIssuerValidatorOptions	100%
Microsoft.Identity.Web.AccountExtensions	100%	100%
Microsoft.Identity.Web.AppContextSwitches	100%	100%
Microsoft.Identity.Web.AppServicesAuthenticationBuilderExtensions	100%
Microsoft.Identity.Web.AppServicesAuthenticationHandler	0%	0%
Microsoft.Identity.Web.AppServicesAuthenticationInformation	78.8%	59%
Microsoft.Identity.Web.AppServicesAuthenticationTokenAcquisition	0%	0%
Microsoft.Identity.Web.AuthorityHelpers	100%	92.3%
Microsoft.Identity.Web.AuthorizeForScopesAttribute	8.3%	7.1%
Microsoft.Identity.Web.AzureADB2COpenIDConnectEventHandlers	97.5%	87.5%
Microsoft.Identity.Web.AzureFunctionsAuthenticationHttpContextExtension	0%	0%
Microsoft.Identity.Web.ClaimsPrincipalFactory	81.2%	100%
Microsoft.Identity.Web.CookiePolicyOptionsExtensions	95.8%	90%
Microsoft.Identity.Web.DefaultMicrosoftIdentityAuthenticationDelegatingHand lerFactory	100%
Microsoft.Identity.Web.DownstreamWebApi	10.8%	0%
Microsoft.Identity.Web.DownstreamWebApiExtensions	100%
Microsoft.Identity.Web.DownstreamWebApiGenericExtensions	0%	0%
Microsoft.Identity.Web.DownstreamWebApiOptions	94.7%	50%
Microsoft.Identity.Web.Extensions	100%	100%
Microsoft.Identity.Web.IDownstreamWebApi	0%
Microsoft.Identity.Web.IncrementalConsentAndConditionalAccessHelper	95.8%	87.5%
Microsoft.Identity.Web.MergedOptionsValidation	100%	100%
Microsoft.Identity.Web.MicrosoftIdentityAppAuthenticationMessageHandler	100%	100%
Microsoft.Identity.Web.MicrosoftIdentityAppCallsWebApiAuthenticationBuilder Extension	0%	0%
Microsoft.Identity.Web.MicrosoftIdentityAuthenticationBaseMessageHandler	96%	62.5%
Microsoft.Identity.Web.MicrosoftIdentityAuthenticationBaseOptions	100%	50%
Microsoft.Identity.Web.MicrosoftIdentityAuthenticationMessageHandlerHttpCli entBuilderExtensions	91.3%
Microsoft.Identity.Web.MicrosoftIdentityAuthenticationMessageHandlerOptions	90%
Microsoft.Identity.Web.MicrosoftIdentityBlazorServiceCollectionExtensions	100%
Microsoft.Identity.Web.MicrosoftIdentityConsentAndConditionalAccessHandler	4.9%	0%
Microsoft.Identity.Web.MicrosoftIdentityServiceHandler	0%
Microsoft.Identity.Web.MicrosoftIdentityUserAuthenticationMessageHandler	100%	66.6%
Microsoft.Identity.Web.MicrosoftIdentityWebApiAuthenticationBuilder	78.9%	0%
Microsoft.Identity.Web.MicrosoftIdentityWebApiAuthenticationBuilderExtensio ns	62.2%	27.7%
Microsoft.Identity.Web.MicrosoftIdentityWebApiAuthenticationBuilderWithConf iguration	100%
Microsoft.Identity.Web.MicrosoftIdentityWebApiServiceCollectionExtensions	0%
Microsoft.Identity.Web.MicrosoftIdentityWebAppAuthenticationBuilder	94.6%	83.3%
Microsoft.Identity.Web.MicrosoftIdentityWebAppAuthenticationBuilderExtensio ns	97%	88.7%
Microsoft.Identity.Web.MicrosoftIdentityWebAppAuthenticationBuilderWithConf iguration	81.2%
Microsoft.Identity.Web.MicrosoftIdentityWebAppServiceCollectionExtensions	100%
Microsoft.Identity.Web.PolicyBuilderExtensions	100%
Microsoft.Identity.Web.RequiredScopeExtensions	40%
Microsoft.Identity.Web.RequiredScopeOrAppPermissionExtensions	33.3%
Microsoft.Identity.Web.RequireScopeOptions	100%	50%
Microsoft.Identity.Web.RequireScopeOrAppPermissionOptions	100%	50%
Microsoft.Identity.Web.Resource.JwtBearerMiddlewareDiagnostics	100%	100%
Microsoft.Identity.Web.Resource.MicrosoftIdentityIssuerValidatorFactory	90%	62.5%
Microsoft.Identity.Web.Resource.OpenIdConnectMiddlewareDiagnostics	100%	83.3%
Microsoft.Identity.Web.Resource.RegisterValidAudience	95.6%	90%
Microsoft.Identity.Web.Resource.RequiredScopeAttribute	0%
Microsoft.Identity.Web.Resource.RequiredScopeOrAppPermissionAttribute	0%
Microsoft.Identity.Web.Resource.RolesRequiredHttpContextExtensions	100%	100%
Microsoft.Identity.Web.Resource.ScopesRequiredHttpContextExtensions	100%	100%
Microsoft.Identity.Web.ScopeAuthorizationHandler	90.3%	73%
Microsoft.Identity.Web.ScopeAuthorizationRequirement	100%	50%
Microsoft.Identity.Web.ScopeOrAppPermissionAuthorizationHandler	90.2%	72.9%
Microsoft.Identity.Web.ScopeOrAppPermissionAuthorizationRequirement	78.9%	60%
Microsoft.Identity.Web.TempDataLoginErrorAccessor	15%	25%
Microsoft.Identity.Web.TokenAcquisitionAppTokenCredential	0%
Microsoft.Identity.Web.TokenAcquisitionTokenCredential	0%
Microsoft.Identity.Web.TokenCacheProviders.Session.MsalSessionTokenCachePro vider	0%	0%
Microsoft.Identity.Web.TokenCacheProviders.Session.SessionTokenCacheProvide rExtension	0%	0%

Microsoft.Identity.Web.Certificate - 41.4%

Name	Line	Branch
Microsoft.Identity.Web.Certificate	41.4%	26.5%
Microsoft.Identity.Web.Base64EncodedCertificateLoader	90.9%	66.6%
Microsoft.Identity.Web.CertificateDescription	87.9%
Microsoft.Identity.Web.CertificateLoaderHelper	29.1%	20%
Microsoft.Identity.Web.DefaultCertificateLoader	45.6%	31.8%
Microsoft.Identity.Web.DefaultCredentialsLoader	54.7%	50%
Microsoft.Identity.Web.FromPathCertificateLoader	0%
Microsoft.Identity.Web.KeyVaultCertificateLoader	0%	0%
Microsoft.Identity.Web.SignedAssertionFilePathCredentialsLoader	93.7%	100%
Microsoft.Identity.Web.SignedAssertionFromManagedIdentityCredentialLoader	15.7%	0%
Microsoft.Identity.Web.StoreWithDistinguishedNameCertificateLoader	0%
Microsoft.Identity.Web.StoreWithThumbprintCertificateLoader	0%

Microsoft.Identity.Web.Certificateless - 40.1%

Name	Line	Branch
Microsoft.Identity.Web.Certificateless	40.1%	43.2%
Microsoft.Identity.Web.AzureIdentityForKubernetesClientAssertion	58.1%	63.1%
Microsoft.Identity.Web.CertificatelessOptions	100%
Microsoft.Identity.Web.ClientAssertion	100%
Microsoft.Identity.Web.ClientAssertionProviderBase	100%	80%
Microsoft.Identity.Web.ManagedIdentityClientAssertion	0%	0%

Microsoft.Identity.Web.Diagnostics - 10.2%

Name	Line	Branch
Microsoft.Identity.Web.Diagnostics	10.2%	7.1%
Microsoft.Identity.Web.Diagnostics.OsHelper	33.3%
Microsoft.Identity.Web.Throws	8.6%	7.1%

Microsoft.Identity.Web.DownstreamApi - 14.5%

Name	Line	Branch
Microsoft.Identity.Web.DownstreamApi	14.5%	16.1%
Microsoft.Extensions.Configuration.Binder.SourceGeneration	0%	0%
Microsoft.Identity.Web.DownstreamApi	15.4%	21.6%
Microsoft.Identity.Web.DownstreamApiExtensions	51.4%	80%
Microsoft.Identity.Web.DownstreamApiLoggingEventId	100%
System.Runtime.CompilerServices	0%

Microsoft.Identity.Web.MicrosoftGraph - 42%

Name	Line	Branch
Microsoft.Identity.Web.MicrosoftGraph	42%	4.5%
Microsoft.Identity.Web.BaseRequestExtensions	0%	0%
Microsoft.Identity.Web.GraphServiceCollectionExtensions	82.7%	50%
Microsoft.Identity.Web.MicrosoftGraphExtensions	67.7%
Microsoft.Identity.Web.MicrosoftGraphOptions	100%
Microsoft.Identity.Web.TokenAcquisitionAuthenticationProvider	13.5%	0%
Microsoft.Identity.Web.TokenAcquisitionAuthenticationProviderOption	16.6%

Microsoft.Identity.Web.Test.Common - 70.9%

Name	Line	Branch
Microsoft.Identity.Web.Test.Common	70.9%	66.6%
Microsoft.Identity.Web.Test.Common.Asserts	100%
Microsoft.Identity.Web.Test.Common.Mocks.LoggerMock`1	50%	100%
Microsoft.Identity.Web.Test.Common.Mocks.MockHttpClientFactory	100%	33.3%
Microsoft.Identity.Web.Test.Common.Mocks.MockHttpContextAccessor	100%
Microsoft.Identity.Web.Test.Common.Mocks.MockHttpCreator	68.9%
Microsoft.Identity.Web.Test.Common.Mocks.MockHttpMessageHandler	80.4%	81.2%
Microsoft.Identity.Web.Test.Common.Mocks.QueryStringParser	86.8%	85.7%
Microsoft.Identity.Web.Test.Common.Mocks.QueueHttpMessageHandler	57.1%	37.5%
Microsoft.Identity.Web.Test.Common.TestConstants	100%
Microsoft.Identity.Web.Test.Common.TestHelpers.ExternalApp	0%	0%
Microsoft.Identity.Web.Test.Common.TestHelpers.HttpContextUtilities	100%
Microsoft.Identity.Web.Test.Common.TestHelpers.InMemoryTokenCache	0%	0%
Microsoft.Identity.Web.Test.Common.TestHelpers.MsalTestTokenCacheProvider	26.6%
Microsoft.Identity.Web.Test.Common.TestHelpers.TestMsalDistributedTokenCach eAdapter	100%
Microsoft.Identity.Web.Test.Common.TestHelpers.TestOptionsMonitor`1	50%	0%

Microsoft.Identity.Web.TokenAcquisition - 52.3%

Name	Line	Branch
Microsoft.Identity.Web.TokenAcquisition	52.3%	55.1%
Microsoft.Identity.Web.ApplicationBuilderExtensions	0%
Microsoft.Identity.Web.AuthCodeRedemptionParameters	100%
Microsoft.Identity.Web.CiamAuthorityHelper	100%	92.8%
Microsoft.Identity.Web.ClientInfo	100%	87.5%
Microsoft.Identity.Web.ConfidentialClientApplicationBuilderExtension	79%	60.5%
Microsoft.Identity.Web.ConfidentialClientApplicationOptionsMerger	100%	50%
Microsoft.Identity.Web.DefaultAuthorizationHeaderProvider	54.9%	26.6%
Microsoft.Identity.Web.DefaultTokenAcquirerFactoryImplementation	1.6%	0%
Microsoft.Identity.Web.Experimental.CertificateChangeEventArg	0%
Microsoft.Identity.Web.Extensibility.BaseAuthorizationHeaderProvider	45.4%
Microsoft.Identity.Web.Hosts.DefaultTokenAcquisitionHost	38.4%	0%
Microsoft.Identity.Web.HttpContextExtensions	100%
Microsoft.Identity.Web.IdHelper	95.8%	50%
Microsoft.Identity.Web.Internal.WebApiBuilders	100%	100%
Microsoft.Identity.Web.ITokenAcquisition	0%
Microsoft.Identity.Web.JwtBearerOptionsMerger	0%	0%
Microsoft.Identity.Web.LoggingEventId	100%
Microsoft.Identity.Web.LoggingOptions	100%
Microsoft.Identity.Web.MergedOptions	93.4%	92%
Microsoft.Identity.Web.MergedOptionsStore	100%
Microsoft.Identity.Web.MicrosoftIdentityAppCallsWebApiAuthenticationBuilder	83.3%	100%
Microsoft.Identity.Web.MicrosoftIdentityApplicationOptionsMerger	60%	0%
Microsoft.Identity.Web.MicrosoftIdentityBaseAuthenticationBuilder	85.1%	78.5%
Microsoft.Identity.Web.MicrosoftIdentityOptions	100%	75%
Microsoft.Identity.Web.MicrosoftIdentityOptionsMerger	100%	50%
Microsoft.Identity.Web.MicrosoftIdentityWebChallengeUserException	0%
Microsoft.Identity.Web.MsalAspNetCoreHttpClientFactory	50%
Microsoft.Identity.Web.MsAuth10AtPop	100%	100%
Microsoft.Identity.Web.PrincipalExtensionsForSecurityTokens	100%	70%
Microsoft.Identity.Web.ServiceCollectionExtensions	66.6%	64.2%
Microsoft.Identity.Web.TokenAcquirer	0%	0%
Microsoft.Identity.Web.TokenAcquirerFactory	55.4%	50%
Microsoft.Identity.Web.TokenAcquisition	22.4%	20.2%
Microsoft.Identity.Web.TokenAcquisitionAspNetCore	4.6%	0%
Microsoft.Identity.Web.TokenAcquisitionAspnetCoreHost	40.4%	23.6%
Microsoft.Identity.Web.TokenAcquisitionExtensionOptions	100%	100%
Microsoft.Identity.Web.TokenAcquisitionOptions	100%
Microsoft.Identity.Web.Util.Base64UrlHelpers	93.4%	81.4%

Microsoft.Identity.Web.TokenCache - 80.8%

Name	Line	Branch
Microsoft.Identity.Web.TokenCache	80.8%	82.6%
Microsoft.Identity.Web.ClaimsPrincipalExtensions	96.7%	100%
Microsoft.Identity.Web.LoggingEventId	100%
Microsoft.Identity.Web.TokenCacheExtensions	100%
Microsoft.Identity.Web.TokenCacheProviders.CacheSerializerHints	100%
Microsoft.Identity.Web.TokenCacheProviders.Distributed.DistributedTokenCach eAdapterExtension	100%
Microsoft.Identity.Web.TokenCacheProviders.Distributed.MsalDistributedToken CacheAdapter	83%	83.3%
Microsoft.Identity.Web.TokenCacheProviders.Distributed.MsalDistributedToken CacheAdapterOptions	88.8%
Microsoft.Identity.Web.TokenCacheProviders.InMemory.InMemoryTokenCacheProvi derExtension	100%
Microsoft.Identity.Web.TokenCacheProviders.InMemory.MsalMemoryTokenCacheOpt ions	100%
Microsoft.Identity.Web.TokenCacheProviders.InMemory.MsalMemoryTokenCachePro vider	83.8%	81.8%
Microsoft.Identity.Web.TokenCacheProviders.MeasureDurationResult	100%
Microsoft.Identity.Web.TokenCacheProviders.MeasureDurationResult`1	0%
Microsoft.Identity.Web.TokenCacheProviders.MsalAbstractTokenCacheProvider	50.7%	66.6%
Microsoft.Identity.Web.TokenCacheProviders.Utility	54.5%

neha-bhargava · 2024-11-08T18:41:04Z

Need more time to think this through. ETA is 11/8 eod.

@jennyf19 updated as suggested. Could you please re-review. Thanks!

…/microsoft-identity-web into nebharg/ExtensionForROPC

github-actions · 2024-11-08T20:19:05Z

Summary


Generated on:	11/8/2024 - 8:19:04 PM
Coverage date:	11/8/2024 - 8:19:02 PM
Parser:	Cobertura
Assemblies:	9
Classes:	158
Files:	166
Line coverage:	51.2% (3202 of 6249)
Covered lines:	3202
Uncovered lines:	3047
Coverable lines:	6249
Total lines:	19990
Branch coverage:	48.5% (1155 of 2378)
Covered branches:	1155
Total branches:	2378
Method coverage:	Feature is only available for sponsors

Coverage

Microsoft.Identity.Web - 63.4%

Name	Line	Branch
Microsoft.Identity.Web	63.4%	56.9%
Microsoft.Identity.Web.AadIssuerValidatorOptions	100%
Microsoft.Identity.Web.AccountExtensions	100%	100%
Microsoft.Identity.Web.AppContextSwitches	100%	100%
Microsoft.Identity.Web.AppServicesAuthenticationBuilderExtensions	100%
Microsoft.Identity.Web.AppServicesAuthenticationHandler	0%	0%
Microsoft.Identity.Web.AppServicesAuthenticationInformation	78.8%	59%
Microsoft.Identity.Web.AppServicesAuthenticationTokenAcquisition	0%	0%
Microsoft.Identity.Web.AuthorityHelpers	100%	92.3%
Microsoft.Identity.Web.AuthorizeForScopesAttribute	8.3%	7.1%
Microsoft.Identity.Web.AzureADB2COpenIDConnectEventHandlers	97.5%	87.5%
Microsoft.Identity.Web.AzureFunctionsAuthenticationHttpContextExtension	0%	0%
Microsoft.Identity.Web.ClaimsPrincipalFactory	81.2%	100%
Microsoft.Identity.Web.CookiePolicyOptionsExtensions	95.8%	90%
Microsoft.Identity.Web.DefaultMicrosoftIdentityAuthenticationDelegatingHand lerFactory	100%
Microsoft.Identity.Web.DownstreamWebApi	10.8%	0%
Microsoft.Identity.Web.DownstreamWebApiExtensions	100%
Microsoft.Identity.Web.DownstreamWebApiGenericExtensions	0%	0%
Microsoft.Identity.Web.DownstreamWebApiOptions	94.7%	50%
Microsoft.Identity.Web.Extensions	100%	100%
Microsoft.Identity.Web.IDownstreamWebApi	0%
Microsoft.Identity.Web.IncrementalConsentAndConditionalAccessHelper	95.8%	87.5%
Microsoft.Identity.Web.MergedOptionsValidation	100%	100%
Microsoft.Identity.Web.MicrosoftIdentityAppAuthenticationMessageHandler	100%	100%
Microsoft.Identity.Web.MicrosoftIdentityAppCallsWebApiAuthenticationBuilder Extension	0%	0%
Microsoft.Identity.Web.MicrosoftIdentityAuthenticationBaseMessageHandler	96%	62.5%
Microsoft.Identity.Web.MicrosoftIdentityAuthenticationBaseOptions	100%	50%
Microsoft.Identity.Web.MicrosoftIdentityAuthenticationMessageHandlerHttpCli entBuilderExtensions	91.3%
Microsoft.Identity.Web.MicrosoftIdentityAuthenticationMessageHandlerOptions	90%
Microsoft.Identity.Web.MicrosoftIdentityBlazorServiceCollectionExtensions	100%
Microsoft.Identity.Web.MicrosoftIdentityConsentAndConditionalAccessHandler	4.9%	0%
Microsoft.Identity.Web.MicrosoftIdentityServiceHandler	0%
Microsoft.Identity.Web.MicrosoftIdentityUserAuthenticationMessageHandler	100%	66.6%
Microsoft.Identity.Web.MicrosoftIdentityWebApiAuthenticationBuilder	78.9%	0%
Microsoft.Identity.Web.MicrosoftIdentityWebApiAuthenticationBuilderExtensio ns	62.2%	27.7%
Microsoft.Identity.Web.MicrosoftIdentityWebApiAuthenticationBuilderWithConf iguration	100%
Microsoft.Identity.Web.MicrosoftIdentityWebApiServiceCollectionExtensions	0%
Microsoft.Identity.Web.MicrosoftIdentityWebAppAuthenticationBuilder	94.6%	83.3%
Microsoft.Identity.Web.MicrosoftIdentityWebAppAuthenticationBuilderExtensio ns	97%	88.7%
Microsoft.Identity.Web.MicrosoftIdentityWebAppAuthenticationBuilderWithConf iguration	81.2%
Microsoft.Identity.Web.MicrosoftIdentityWebAppServiceCollectionExtensions	100%
Microsoft.Identity.Web.PolicyBuilderExtensions	100%
Microsoft.Identity.Web.RequiredScopeExtensions	40%
Microsoft.Identity.Web.RequiredScopeOrAppPermissionExtensions	33.3%
Microsoft.Identity.Web.RequireScopeOptions	100%	50%
Microsoft.Identity.Web.RequireScopeOrAppPermissionOptions	100%	50%
Microsoft.Identity.Web.Resource.JwtBearerMiddlewareDiagnostics	100%	100%
Microsoft.Identity.Web.Resource.MicrosoftIdentityIssuerValidatorFactory	90%	62.5%
Microsoft.Identity.Web.Resource.OpenIdConnectMiddlewareDiagnostics	100%	83.3%
Microsoft.Identity.Web.Resource.RegisterValidAudience	95.6%	90%
Microsoft.Identity.Web.Resource.RequiredScopeAttribute	0%
Microsoft.Identity.Web.Resource.RequiredScopeOrAppPermissionAttribute	0%
Microsoft.Identity.Web.Resource.RolesRequiredHttpContextExtensions	100%	100%
Microsoft.Identity.Web.Resource.ScopesRequiredHttpContextExtensions	100%	100%
Microsoft.Identity.Web.ScopeAuthorizationHandler	90.3%	73%
Microsoft.Identity.Web.ScopeAuthorizationRequirement	100%	50%
Microsoft.Identity.Web.ScopeOrAppPermissionAuthorizationHandler	90.2%	72.9%
Microsoft.Identity.Web.ScopeOrAppPermissionAuthorizationRequirement	78.9%	60%
Microsoft.Identity.Web.TempDataLoginErrorAccessor	15%	25%
Microsoft.Identity.Web.TokenAcquisitionAppTokenCredential	0%
Microsoft.Identity.Web.TokenAcquisitionTokenCredential	0%
Microsoft.Identity.Web.TokenCacheProviders.Session.MsalSessionTokenCachePro vider	0%	0%
Microsoft.Identity.Web.TokenCacheProviders.Session.SessionTokenCacheProvide rExtension	0%	0%

Microsoft.Identity.Web.Certificate - 41.4%

Name	Line	Branch
Microsoft.Identity.Web.Certificate	41.4%	26.5%
Microsoft.Identity.Web.Base64EncodedCertificateLoader	90.9%	66.6%
Microsoft.Identity.Web.CertificateDescription	87.9%
Microsoft.Identity.Web.CertificateLoaderHelper	29.1%	20%
Microsoft.Identity.Web.DefaultCertificateLoader	45.6%	31.8%
Microsoft.Identity.Web.DefaultCredentialsLoader	54.7%	50%
Microsoft.Identity.Web.FromPathCertificateLoader	0%
Microsoft.Identity.Web.KeyVaultCertificateLoader	0%	0%
Microsoft.Identity.Web.SignedAssertionFilePathCredentialsLoader	93.7%	100%
Microsoft.Identity.Web.SignedAssertionFromManagedIdentityCredentialLoader	15.7%	0%
Microsoft.Identity.Web.StoreWithDistinguishedNameCertificateLoader	0%
Microsoft.Identity.Web.StoreWithThumbprintCertificateLoader	0%

Microsoft.Identity.Web.Certificateless - 40.1%

Name	Line	Branch
Microsoft.Identity.Web.Certificateless	40.1%	43.2%
Microsoft.Identity.Web.AzureIdentityForKubernetesClientAssertion	58.1%	63.1%
Microsoft.Identity.Web.CertificatelessOptions	100%
Microsoft.Identity.Web.ClientAssertion	100%
Microsoft.Identity.Web.ClientAssertionProviderBase	100%	80%
Microsoft.Identity.Web.ManagedIdentityClientAssertion	0%	0%

Microsoft.Identity.Web.Diagnostics - 10.2%

Name	Line	Branch
Microsoft.Identity.Web.Diagnostics	10.2%	7.1%
Microsoft.Identity.Web.Diagnostics.OsHelper	33.3%
Microsoft.Identity.Web.Throws	8.6%	7.1%

Microsoft.Identity.Web.DownstreamApi - 14.5%

Name	Line	Branch
Microsoft.Identity.Web.DownstreamApi	14.5%	16.1%
Microsoft.Extensions.Configuration.Binder.SourceGeneration	0%	0%
Microsoft.Identity.Web.DownstreamApi	15.4%	21.6%
Microsoft.Identity.Web.DownstreamApiExtensions	51.4%	80%
Microsoft.Identity.Web.DownstreamApiLoggingEventId	100%
System.Runtime.CompilerServices	0%

Microsoft.Identity.Web.MicrosoftGraph - 42%

Name	Line	Branch
Microsoft.Identity.Web.MicrosoftGraph	42%	4.5%
Microsoft.Identity.Web.BaseRequestExtensions	0%	0%
Microsoft.Identity.Web.GraphServiceCollectionExtensions	82.7%	50%
Microsoft.Identity.Web.MicrosoftGraphExtensions	67.7%
Microsoft.Identity.Web.MicrosoftGraphOptions	100%
Microsoft.Identity.Web.TokenAcquisitionAuthenticationProvider	13.5%	0%
Microsoft.Identity.Web.TokenAcquisitionAuthenticationProviderOption	16.6%

Microsoft.Identity.Web.Test.Common - 70.9%

Name	Line	Branch
Microsoft.Identity.Web.Test.Common	70.9%	66.6%
Microsoft.Identity.Web.Test.Common.Asserts	100%
Microsoft.Identity.Web.Test.Common.Mocks.LoggerMock`1	50%	100%
Microsoft.Identity.Web.Test.Common.Mocks.MockHttpClientFactory	100%	33.3%
Microsoft.Identity.Web.Test.Common.Mocks.MockHttpContextAccessor	100%
Microsoft.Identity.Web.Test.Common.Mocks.MockHttpCreator	68.9%
Microsoft.Identity.Web.Test.Common.Mocks.MockHttpMessageHandler	80.4%	81.2%
Microsoft.Identity.Web.Test.Common.Mocks.QueryStringParser	86.8%	85.7%
Microsoft.Identity.Web.Test.Common.Mocks.QueueHttpMessageHandler	57.1%	37.5%
Microsoft.Identity.Web.Test.Common.TestConstants	100%
Microsoft.Identity.Web.Test.Common.TestHelpers.ExternalApp	0%	0%
Microsoft.Identity.Web.Test.Common.TestHelpers.HttpContextUtilities	100%
Microsoft.Identity.Web.Test.Common.TestHelpers.InMemoryTokenCache	0%	0%
Microsoft.Identity.Web.Test.Common.TestHelpers.MsalTestTokenCacheProvider	26.6%
Microsoft.Identity.Web.Test.Common.TestHelpers.TestMsalDistributedTokenCach eAdapter	100%
Microsoft.Identity.Web.Test.Common.TestHelpers.TestOptionsMonitor`1	50%	0%

Microsoft.Identity.Web.TokenAcquisition - 52.3%

Name	Line	Branch
Microsoft.Identity.Web.TokenAcquisition	52.3%	55.1%
Microsoft.Identity.Web.ApplicationBuilderExtensions	0%
Microsoft.Identity.Web.AuthCodeRedemptionParameters	100%
Microsoft.Identity.Web.CiamAuthorityHelper	100%	92.8%
Microsoft.Identity.Web.ClientInfo	100%	87.5%
Microsoft.Identity.Web.ConfidentialClientApplicationBuilderExtension	79%	60.5%
Microsoft.Identity.Web.ConfidentialClientApplicationOptionsMerger	100%	50%
Microsoft.Identity.Web.DefaultAuthorizationHeaderProvider	54.9%	26.6%
Microsoft.Identity.Web.DefaultTokenAcquirerFactoryImplementation	1.6%	0%
Microsoft.Identity.Web.Experimental.CertificateChangeEventArg	0%
Microsoft.Identity.Web.Extensibility.BaseAuthorizationHeaderProvider	45.4%
Microsoft.Identity.Web.Hosts.DefaultTokenAcquisitionHost	38.4%	0%
Microsoft.Identity.Web.HttpContextExtensions	100%
Microsoft.Identity.Web.IdHelper	95.8%	50%
Microsoft.Identity.Web.Internal.WebApiBuilders	100%	100%
Microsoft.Identity.Web.ITokenAcquisition	0%
Microsoft.Identity.Web.JwtBearerOptionsMerger	0%	0%
Microsoft.Identity.Web.LoggingEventId	100%
Microsoft.Identity.Web.LoggingOptions	100%
Microsoft.Identity.Web.MergedOptions	93.4%	92%
Microsoft.Identity.Web.MergedOptionsStore	100%
Microsoft.Identity.Web.MicrosoftIdentityAppCallsWebApiAuthenticationBuilder	83.3%	100%
Microsoft.Identity.Web.MicrosoftIdentityApplicationOptionsMerger	60%	0%
Microsoft.Identity.Web.MicrosoftIdentityBaseAuthenticationBuilder	85.1%	78.5%
Microsoft.Identity.Web.MicrosoftIdentityOptions	100%	75%
Microsoft.Identity.Web.MicrosoftIdentityOptionsMerger	100%	50%
Microsoft.Identity.Web.MicrosoftIdentityWebChallengeUserException	0%
Microsoft.Identity.Web.MsalAspNetCoreHttpClientFactory	50%
Microsoft.Identity.Web.MsAuth10AtPop	100%	100%
Microsoft.Identity.Web.PrincipalExtensionsForSecurityTokens	100%	70%
Microsoft.Identity.Web.ServiceCollectionExtensions	66.6%	64.2%
Microsoft.Identity.Web.TokenAcquirer	0%	0%
Microsoft.Identity.Web.TokenAcquirerFactory	55.4%	50%
Microsoft.Identity.Web.TokenAcquisition	22.4%	20.2%
Microsoft.Identity.Web.TokenAcquisitionAspNetCore	4.6%	0%
Microsoft.Identity.Web.TokenAcquisitionAspnetCoreHost	40.4%	23.6%
Microsoft.Identity.Web.TokenAcquisitionExtensionOptions	100%	100%
Microsoft.Identity.Web.TokenAcquisitionOptions	100%
Microsoft.Identity.Web.Util.Base64UrlHelpers	93.4%	81.4%

Microsoft.Identity.Web.TokenCache - 80.8%

Name	Line	Branch
Microsoft.Identity.Web.TokenCache	80.8%	82.6%
Microsoft.Identity.Web.ClaimsPrincipalExtensions	96.7%	100%
Microsoft.Identity.Web.LoggingEventId	100%
Microsoft.Identity.Web.TokenCacheExtensions	100%
Microsoft.Identity.Web.TokenCacheProviders.CacheSerializerHints	100%
Microsoft.Identity.Web.TokenCacheProviders.Distributed.DistributedTokenCach eAdapterExtension	100%
Microsoft.Identity.Web.TokenCacheProviders.Distributed.MsalDistributedToken CacheAdapter	83%	83.3%
Microsoft.Identity.Web.TokenCacheProviders.Distributed.MsalDistributedToken CacheAdapterOptions	88.8%
Microsoft.Identity.Web.TokenCacheProviders.InMemory.InMemoryTokenCacheProvi derExtension	100%
Microsoft.Identity.Web.TokenCacheProviders.InMemory.MsalMemoryTokenCacheOpt ions	100%
Microsoft.Identity.Web.TokenCacheProviders.InMemory.MsalMemoryTokenCachePro vider	83.8%	81.8%
Microsoft.Identity.Web.TokenCacheProviders.MeasureDurationResult	100%
Microsoft.Identity.Web.TokenCacheProviders.MeasureDurationResult`1	0%
Microsoft.Identity.Web.TokenCacheProviders.MsalAbstractTokenCacheProvider	50.7%	66.6%
Microsoft.Identity.Web.TokenCacheProviders.Utility	54.5%

jmprieur

LGTM
Thanks @neha-bhargava

Add extension to update parameters for ROPC flow

4724869

neha-bhargava marked this pull request as ready for review November 5, 2024 23:02

neha-bhargava requested a review from a team as a code owner November 5, 2024 23:02

This comment was marked as duplicate.

Sign in to view

jmprieur reviewed Nov 5, 2024

View reviewed changes

Update test to validate params added in extension

cc06023

bgavrilMS reviewed Nov 6, 2024

View reviewed changes

src/Microsoft.Identity.Web.TokenAcquisition/TokenAcquisition.cs Show resolved Hide resolved

Missed to commit the line

2eb6b7d

bgavrilMS approved these changes Nov 7, 2024

View reviewed changes

jennyf19 requested changes Nov 7, 2024

View reviewed changes

bgavrilMS reviewed Nov 8, 2024

View reviewed changes

tests/Microsoft.Identity.Web.Test/TokenAcquisitionAddInTests.cs Show resolved Hide resolved

neha-bhargava and others added 2 commits November 8, 2024 09:58

Update the name to BeforeTokenAcquisitionForTestUser

da9bb2b

Merge branch 'master' into nebharg/ExtensionForROPC

ec632ae

neha-bhargava changed the title ~~Add extension to update parameters for ROPC flow~~ Add extensibility to update parameters for ROPC flow Nov 8, 2024

neha-bhargava added 2 commits November 8, 2024 12:01

Try to resolve the warning

ae92b6a

Merge branch 'nebharg/ExtensionForROPC' of https://github.com/AzureAD…

a020962

…/microsoft-identity-web into nebharg/ExtensionForROPC

jmprieur approved these changes Nov 9, 2024

View reviewed changes

jennyf19 approved these changes Nov 9, 2024

View reviewed changes

neha-bhargava merged commit 7c7fab6 into master Nov 11, 2024

neha-bhargava deleted the nebharg/ExtensionForROPC branch November 11, 2024 16:58

westin-m mentioned this pull request Nov 11, 2024

Declare ROPC extensions in net 9 API #3136

Merged

dependabot bot mentioned this pull request Jan 30, 2026

Bump Microsoft.Identity.Web from 3.2.2 to 3.8.2 jclopeztavera/datasharing#2

Merged

dependabot bot mentioned this pull request Feb 22, 2026

Bump the nuget group with 1 update aurelianware/clouddentaloffice#11

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add extensibility to update parameters for ROPC flow#3130

Add extensibility to update parameters for ROPC flow#3130
neha-bhargava merged 7 commits intomasterfrom
nebharg/ExtensionForROPC

neha-bhargava commented Nov 5, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Nov 5, 2024

Uh oh!

This comment was marked as duplicate.

jmprieur left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

neha-bhargava commented Nov 6, 2024

Uh oh!

Uh oh!

github-actions bot commented Nov 7, 2024

Uh oh!

jennyf19 left a comment

Uh oh!

Uh oh!

github-actions bot commented Nov 8, 2024

Uh oh!

neha-bhargava commented Nov 8, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Nov 8, 2024

Uh oh!

jmprieur left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

neha-bhargava commented Nov 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Add extension method to update the parameters for ROPC flow

Description

Uh oh!

github-actions bot commented Nov 5, 2024

Summary

Coverage

Uh oh!

This comment was marked as duplicate.

jmprieur left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

neha-bhargava commented Nov 6, 2024

Uh oh!

Uh oh!

github-actions bot commented Nov 7, 2024

Summary

Coverage

Uh oh!

jennyf19 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Nov 8, 2024

Summary

Coverage

Uh oh!

neha-bhargava commented Nov 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 8, 2024

Summary

Coverage

Uh oh!

jmprieur left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

neha-bhargava commented Nov 5, 2024 •

edited

Loading

neha-bhargava commented Nov 8, 2024 •

edited

Loading