Skip to content

Treat warnings as errors#3166

Merged
keegan-caruso merged 3 commits intomasterfrom
kecaruso/warn-as-error
Dec 26, 2024
Merged

Treat warnings as errors#3166
keegan-caruso merged 3 commits intomasterfrom
kecaruso/warn-as-error

Conversation

@keegan-caruso
Copy link
Copy Markdown
Contributor

Treat warnings as errors.

SYSLIB0057 is using overloads that don't have direct equivalents.

Suppress SYSLIB0057
@keegan-caruso keegan-caruso requested a review from a team as a code owner December 7, 2024 04:29
@pmaytak pmaytak requested a review from Copilot December 20, 2024 22:01
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 8 changed files in this pull request and generated no comments.

Files not reviewed (3)
  • Directory.Build.props: Language not supported
  • tests/E2E Tests/TokenAcquirerTests/CertificateRotationTest.cs: Evaluated as low risk
  • tests/Microsoft.Identity.Web.Test/Certificates/CertificateDescriptionTests.cs: Evaluated as low risk

@keegan-caruso keegan-caruso merged commit bfc7b6b into master Dec 26, 2024
@keegan-caruso keegan-caruso deleted the kecaruso/warn-as-error branch December 26, 2024 18:07
keegan-caruso added a commit that referenced this pull request Dec 31, 2024
This was referenced Aug 1, 2025
This was referenced Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants