Include the thrown exception in CertificateChangeEventArg#3428
Merged
keegan-caruso merged 3 commits intoAzureAD:masterfrom Jul 23, 2025
Merged
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree company="Microsoft" |
jmprieur
approved these changes
Jul 21, 2025
keegan-caruso
approved these changes
Jul 21, 2025
Contributor
keegan-caruso
left a comment
There was a problem hiding this comment.
changes LGTM, are there any tests to add at this level?
Contributor
Author
There's no clear test that this can be added to, and as this is simply setting a property, I'm not sure of the value of creating a new test just for this. |
bgavrilMS
approved these changes
Jul 23, 2025
This was referenced Aug 15, 2025
Merged
Closed
Closed
This was referenced Dec 8, 2025
This was referenced Dec 18, 2025
This was referenced Dec 29, 2025
Closed
This was referenced Jan 5, 2026
Closed
This was referenced Jan 12, 2026
Closed
This was referenced Jan 26, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include the thrown exception in CertificateChangeEventArg
Add in the thrown exception into CertificateChangeEventArg so that subscriber can know why the change was triggered (in the case of deselection)
Description
We intend to consume this information to emit detailed telemetry about certificate usage failures.
#3427