Conversation
Build a new PyPI release of wheels for the ImpactX 25.04 release.
10b9cf7 to
fcfdf84
Compare
This was referenced Apr 22, 2025
Member
Author
|
Nice, that looks good. Merging to trigger the release to PyPI. |
Member
|
Much thanks @ax3l. Important note: For ImpactX release 25.04, I intentionally linked to a later commit #947, instead of #938. This is because #938 was merged before the ISR model (#924). It was very important to include this in the final release. |
Member
Author
|
Thanks! Understood, I was already wondering a bit but that makes sense. Since we use the tag here, that should be included. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build a new PyPI release of wheels for the ImpactX 25.04 release.
We expect the following builds to still fail:
With AMReX 25.04, this is the first ImpactX release that will succeed to build: