Move spin calculations to compute_constants#1304
Move spin calculations to compute_constants#1304ax3l merged 15 commits intoBLAST-ImpactX:developmentfrom
Conversation
| [ | ||
| 0.02, | ||
| 0.02, | ||
| 0.05, |
There was a problem hiding this comment.
This is a necessary change resulting from the typo fix in Quad.H for k < 0.
| T_Real const delta1 = sqrt(1_prt - 2_prt*pt/m_beta + powi<2>(pt)); | ||
|
|
||
| // compute particle relativistic gamma | ||
| T_Real const gamma = gamma_ref * (1_prt - beta_ref*gamma_ref*pt); |
There was a problem hiding this comment.
There should only be one factor of gamma_ref in line 345, which is fixed in the revised line below.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
@cemitch99 uh, I want to do a small PR for Python bindings and benchmarks first, so we can see first hand with the new CI #1309 how much this gains. |
|
Let us merge #1313 and then once it has run on |
Merging this PR will improve performance by 31.53%
Performance Changes
Comparing |
7479980 to
71f90ff
Compare
|
I think this captured all elements we have with spin support so far. The only other 3 are the drift models, which don't affect spin. |
This PR moves many computations for the spin push outside the particle loop into
compute_constants, to improve performance.Close #1288