Skip to content

Comments

FODO Channel Python w/o Slice Diags#1310

Merged
ax3l merged 1 commit intoBLAST-ImpactX:developmentfrom
ax3l:fix-test-slice
Feb 20, 2026
Merged

FODO Channel Python w/o Slice Diags#1310
ax3l merged 1 commit intoBLAST-ImpactX:developmentfrom
ax3l:fix-test-slice

Conversation

@ax3l
Copy link
Member

@ax3l ax3l commented Feb 20, 2026

The inputs file version does not use slice diagnostics, so the Python test should set the same. Speed up by ~2.5x.

The inputs file version does not use slice diagnostics,
so the Python test should set the same. Speed up by ~2.5x.
@ax3l ax3l requested a review from cemitch99 February 20, 2026 07:50
@ax3l ax3l added component: tests examples, tests and benchmarks component: python Python bindings labels Feb 20, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 20, 2026

Merging this PR will not alter performance

✅ 29 untouched benchmarks


Comparing ax3l:fix-test-slice (3b3f886) with development (b735d6e)1

Open in CodSpeed

Footnotes

  1. No successful run was found on development (ab61ac8) during the generation of this report, so b735d6e was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@ax3l ax3l merged commit dbca50d into BLAST-ImpactX:development Feb 20, 2026
18 checks passed
@ax3l ax3l deleted the fix-test-slice branch February 20, 2026 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: python Python bindings component: tests examples, tests and benchmarks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants