Skip to content

ci: Add tests for PHP 8.4#189

Merged
DASPRiD merged 1 commit intoBacon:mainfrom
Chris53897:patch-1
Oct 7, 2024
Merged

ci: Add tests for PHP 8.4#189
DASPRiD merged 1 commit intoBacon:mainfrom
Chris53897:patch-1

Conversation

@Chris53897
Copy link
Copy Markdown
Contributor

No description provided.

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.59%. Comparing base (f9cc1f5) to head (a7358b3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #189   +/-   ##
=========================================
  Coverage     70.59%   70.59%           
  Complexity      995      995           
=========================================
  Files            49       49           
  Lines          3183     3183           
=========================================
  Hits           2247     2247           
  Misses          936      936           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DASPRiD DASPRiD merged commit 5c8fa87 into Bacon:main Oct 7, 2024
@DASPRiD
Copy link
Copy Markdown
Member

DASPRiD commented Oct 7, 2024

Hm, this did cause some issues in the main CI tests:

https://github.com/Bacon/BaconQrCode/actions/runs/11218336744

@Chris53897
Copy link
Copy Markdown
Contributor Author

Yes. This PR did not run the PHP 8.4 check. I do not know why.
The PHP 8.4 run fails because of https://github.com/Bacon/BaconQrCode/actions/runs/11218336744/job/31181897708#step:6:24

@Chris53897
Copy link
Copy Markdown
Contributor Author

I think we need to wait for
laminas/laminas-stdlib#118

@melroy89
Copy link
Copy Markdown

It's implemented in: laminas/laminas-stdlib#119

@Chris53897 Chris53897 deleted the patch-1 branch February 18, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants