fixes #58: made work in a separate thread#103
Merged
Conversation
2 tasks
jogboms
reviewed
Aug 24, 2022
This reverts commit 80590f2.
jogboms
reviewed
Aug 25, 2022
jogboms
reviewed
Aug 25, 2022
jogboms
left a comment
jogboms
left a comment
There was a problem hiding this comment.
If you could remove the unused imports then it should be good to go. I would also test this on my end.
jogboms
reviewed
Aug 25, 2022
jogboms
approved these changes
Aug 25, 2022
jogboms
reviewed
Aug 25, 2022
mvanbeusekom
requested changes
Aug 25, 2022
Member
mvanbeusekom
left a comment
mvanbeusekom
left a comment
There was a problem hiding this comment.
LGTM modules the last remarks mentioned by @jogboms regarding the unused imports and missing line break.
Contributor
Author
|
Good to hear that! |
Member
|
Update has been published on pub.dev (version 2.0.5) |
|
Thanks @mvanbeusekom |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Fixes #58 by using taskQueue API
Main thread on flutter will freeze
🆕 What is the new behavior (if this is a feature change)?
It wont freeze
💥 Does this PR introduce a breaking change?
No
🤔 Checklist before submitting
master.