Skip to content

Make sure the localeIdentifier is passed correctly#11

Merged
mvanbeusekom merged 2 commits into
developfrom
issue/10
Sep 14, 2020
Merged

Make sure the localeIdentifier is passed correctly#11
mvanbeusekom merged 2 commits into
developfrom
issue/10

Conversation

@mvanbeusekom

Copy link
Copy Markdown
Member

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Bug fix

⤵️ What is the current behavior?

Currently the localeIdentifier is not past correctly to the native side of the plugin.

🆕 What is the new behavior (if this is a feature change)?

Correctly pass the localeIdentifier parameter and act accordingly.

💥 Does this PR introduce a breaking change?

No

🐛 Recommendations for testing

  1. Open the example app;
  2. Pass a correctly locale identifier to the placemarkFromCoordinates and locationFromAddress methods;
  3. Run the example app and verify the app displays the information in the correct locale.

📝 Links to relevant issues/docs

Fixes #10

🤔 Checklist before submitting

  • All projects build
  • Follows style guide lines (code style guide)
  • Relevant documentation was updated
  • Rebased onto current develop

@codecov

codecov Bot commented Sep 14, 2020

Copy link
Copy Markdown

Codecov Report

Merging #11 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop       #11   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          119       119           
=========================================
  Hits           119       119           
Impacted Files Coverage Δ
geocoding/lib/geocoding.dart 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8f2857...054a11f. Read the comment docs.

@mvanbeusekom mvanbeusekom merged commit 1ed09cd into develop Sep 14, 2020
@mvanbeusekom mvanbeusekom deleted the issue/10 branch September 14, 2020 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Passing "localeIdentifier" to placemarkFromCoordinates function is not working

1 participant