Bug fix: Slug generation for values containing ampersand symbol#486
Merged
senghe merged 1 commit intoBitBagCommerce:masterfrom Nov 12, 2023
Merged
Bug fix: Slug generation for values containing ampersand symbol#486senghe merged 1 commit intoBitBagCommerce:masterfrom
senghe merged 1 commit intoBitBagCommerce:masterfrom
Conversation
Member
|
Hi @LinasRam, thanks for your PR! 🎉 I'm merging it 💪 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expected result
While creating/editing a page name in admin panel (
/admin/pages), if it contains ampersand symbol (&), the generated slug should contain all typed letters and remove only ampersand (or other symbols) from it.Example:
Actual result
Whole part after ampersand is cut off from slug.
Example:
Solution
As
&is a special character in URLs, values containing it must be encoded while passing it as query parameter.