feat(sdk-core): added OFC BitGo signing on trading accounts object#8666
Open
alextse-bg wants to merge 3 commits intomasterfrom
Open
feat(sdk-core): added OFC BitGo signing on trading accounts object#8666alextse-bg wants to merge 3 commits intomasterfrom
alextse-bg wants to merge 3 commits intomasterfrom
Conversation
alextse-bg
force-pushed
the
WCN-217
branch
6 times, most recently
from
467a1cc to
d75bd7a
Compare
Contributor
Author
|
reimplements the reverted PR: #8624 Taken out the changes to ofcToken/ofc.ts. Changes to these files has no impact on current code path (since we are signing with the user key right now, |
Contributor
Author
alextse-bg
changed the title
mrdanish26
reviewed
May 5, 2026
Contributor
zahin-mohammad
left a comment
zahin-mohammad
left a comment
There was a problem hiding this comment.
In general lgtm, but please address the as any
alextse-bg
force-pushed
the
WCN-217
branch
2 times, most recently
from
4c63875 to
4a7666a
Compare
make wallet passphrase optional when signing trading account TXs allow the use of prv when signing trading account TXs Ticket: WCN-217-1
When no walletPassphrase is present in the request body or environment, pass undefined to tradingAccount.signPayload() instead of throwing. The SDK routes passphrase-less signing through KMS internally. Ticket: WCN-215-1
mrdanish26
approved these changes
May 6, 2026
zahin-mohammad
approved these changes
May 6, 2026
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TICKET: WCN-217