Repository navigation
ci(triage-labels): add timeout-minutes to the label job (BLO-44648) - #45
Open
allyblockcast[bot] wants to merge 1 commit into
Open
allyblockcast[bot] wants to merge 1 commit into
allyblockcast[bot] wants to merge 1 commit into
Conversation
The v1.2.0 upstream sync (#44) brought in triage-labels.yml with a self-hosted runs-on and no timeout-minutes, which turns onprem-k8s check-unbounded-self-hosted-jobs red. The job is gated to vectorize-io/hindsight and never runs here; the bound is for the guard.
Author
|
🔗 Paperclip issue: BLO-44648 |
![allyblockcast[bot]](https://avatars.githubusercontent.com/u/57363972?s=60&v=4){kind=small}
Author
There was a problem hiding this comment.
Ally — Consolidated PR Review
Lenses: pr-review-toolkit (code, tests, comments, errors, types) + gstack/review + native-codex (applied directly; no nested CLI in the k8s job pod).
Reviewed head: bedabd6
Looks good. One line, timeout-minutes: 10 on triage-labels.yml::label, at job level beside runs-on. That is where the unbounded-self-hosted-jobs guard looks for it. The job is gated if: github.repository == 'vectorize-io/hindsight', so it never runs in this fork. The change has no runtime effect here, as the PR body says.
Critical Issues (0)
Important Issues (0)
Suggestions (1)
- [native-codex]
.github/workflows/triage-labels.yml:17— The PR body asks the next upstream sync to re-apply this patch. That note lives only in the PR body. Add a one-line YAML comment next to the key (e.g.# fork-local: required by onprem-k8s check-unbounded-self-hosted-jobs) so whoever resolves the next sync conflict sees why the line exists. Optional.
Strengths
- Minimal and scoped. It fixes the one job named in the failing guard run and touches nothing else.
- 10 minutes is generous for one checkout plus one Python script that makes a single Gemini call.
Recommended Action
- No blocking changes requested.
- Merge once the remaining required CI checks finish green.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
timeout-minutes: 10totriage-labels.yml::label.The v1.2.0 sync (#44, commit
06ffc1bad) brought this job in with a self-hostedruns-on(default-tools/arc-light) and no timeout. That is the only hindsight entry in onprem-k8scheck-unbounded-self-hosted-jobsrun 42350761103 (2026-11-07 07:20Z cron), which keeps onprem-k8s master red (BLO-44648).The job is gated
if: github.repository == 'vectorize-io/hindsight', so it never runs in this fork. The change has no runtime effect. It only satisfies the static guard.Note for the next upstream sync: re-apply this patch, or the guard goes red again.