This repository was archived by the owner on Feb 26, 2025. It is now read-only.
Fix : Add support for std::byte as Dataset type for c++17 and above#698
Merged
Fix : Add support for std::byte as Dataset type for c++17 and above#698
Conversation
Codecov Report
@@ Coverage Diff @@
## master #698 +/- ##
=======================================
Coverage 81.37% 81.37%
=======================================
Files 67 67
Lines 4248 4248
=======================================
Hits 3457 3457
Misses 791 791
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
alkino
previously approved these changes
Mar 4, 2023
1uc
previously approved these changes
Mar 6, 2023
| DATASET_NAME, {5}, create_datatype<typename details::inspector<TestType>::base_type>()); | ||
|
|
||
| // Write into the initial part of the dataset | ||
| dataset.write(t1); |
Collaborator
There was a problem hiding this comment.
Despite the above tests not doing it, it might be nice to also check:
auto dataset2 = file.createDataSet(DATASET_NAME2, t1);
We could leave this for when we refactor the whole file to be more DRY.
Author
There was a problem hiding this comment.
ok, I leave this for the refactoring later.
1uc
approved these changes
Mar 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add support for std::byte as Dataset type when using c++17 and above
Fixes #480
How to test this?
cmake -DCMAKE_CXX_STANDARD=17 .. make -j8 make testTest System