This repository was archived by the owner on Feb 26, 2025. It is now read-only.
Include Windows.h to uncover more defects on Windows.#723
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #723 +/- ##
==========================================
- Coverage 82.42% 82.39% -0.04%
==========================================
Files 67 67
Lines 4513 4504 -9
==========================================
- Hits 3720 3711 -9
Misses 793 793
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
aca7479 to
d01b019
Compare
Collaborator
Author
d01b019 to
bd4a057
Compare
matz-e
approved these changes
Apr 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The purpose is to make our CI more sensitive to name clashes of macros with tokens we've used in HighFive. The idea is that by including
Windows.hwe should be pulling in many standard macros. Hence we should be able to detect the defect.