This repository was archived by the owner on Feb 26, 2025. It is now read-only.
Complete the low-level wrapper of all used HDF5 functions.#863
Merged
Conversation
6ffefcd to
3c92df8
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #863 +/- ##
==========================================
+ Coverage 85.27% 85.34% +0.06%
==========================================
Files 83 84 +1
Lines 5482 5508 +26
==========================================
+ Hits 4675 4701 +26
Misses 807 807 ☔ View full report in Codecov by Sentry. |
e4d5949 to
03efa93
Compare
03efa93 to
8789038
Compare
This was referenced Dec 4, 2023
8789038 to
bbc4d7e
Compare
bbc4d7e to
b3d812b
Compare
This was referenced Dec 12, 2023
matz-e
approved these changes
Dec 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This wrapper enables us to see more easily notice that an error code is being ignored, makes it very clear how we wrap HDF5 function and encourages us to not ignore unchecked error codes if we see one. It'll make it easier to have uniform error handling. Additionally, it prepares the way towards more interesting features, such as thread-safety or logging each call to HDF5 (for creating pure HDF5 reproducers).
The rules are:
H5?*is wrapped bydetail::h5?_*. We can't reuse the name in a namespace because some of them are macros.detail::nothrowit'll throw whenever the returned value indicates an error.H5?*anddetail::h5?_*are identical.h5?_wrapper.hppwe don't use any HDF5 functions or function macros.