BUG: Fix bugs in Matrix3X1, Stereographic, and OrientationConverterTest#37
Merged
imikejackson merged 1 commit intoBlueQuartzSoftware:developfrom Feb 20, 2026
Merged
Conversation
- Matrix3X1::normalize() (static): Add missing `return true` on success path (undefined behavior) - Matrix3X1::sortAscending(): Fix `this` to `*this` for copy construction and add missing `return outMat` - Stereographic::isValid(): Fix epsilon from 1.0E15 to 1.0E-15 (validation was effectively disabled) - OrientationConverterTest: Fix tolerance from 1.0E6 to 1.0E-6 and compare via orientation matrices to handle Euler angle gimbal lock ambiguity Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
return trueon success path (undefined behavior)thisto*thisfor copy construction and add missingreturn outMat