Skip to content

Revert strip removal #1216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SCdF wants to merge 2 commits into from
Closed

Revert strip removal #1216

SCdF wants to merge 2 commits into from

Conversation

@SCdF
Copy link
Contributor

@SCdF SCdF commented Dec 1, 2017

Fixes #1213

@SCdF
Copy link
Contributor Author

SCdF commented Dec 1, 2017 •
edited
Loading

Those tests pass locally for me with the same node version (lts/*). I'm not too familiar with this project so idk if there is a real problem or if the build is flaky.

@kazup01 kazup01 requested a review from sota1235 December 2, 2017 02:20
@kazup01 kazup01 added the awaiting review ❇️ Pull request is awaiting a review. label Dec 2, 2017
@sota1235
Copy link
Contributor

sota1235 commented Dec 2, 2017

Actually, its function is moved to browser/lib/markdownTextHelper.js
Could you use this function?

@kazup01 kazup01 added awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. and removed awaiting review ❇️ Pull request is awaiting a review. labels Dec 2, 2017
@SCdF
Copy link
Contributor Author

SCdF commented Dec 2, 2017

Cool. Closing in favour of #1227.

@SCdF SCdF closed this Dec 2, 2017
@SCdF SCdF deleted the revert-strip-removal branch December 2, 2017 20:31
@kazup01 kazup01 removed the awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. label Dec 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sota1235 sota1235 Awaiting requested review from sota1235

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SCdF @sota1235 @kazup01