Add custom LaTeX delimiters to preferences#1221
Merged
kazup01 merged 4 commits intoBoostIO:masterfrom Dec 4, 2017
Merged
Conversation
sosukesuzuki
requested changes
Dec 2, 2017
Contributor
sosukesuzuki
left a comment
There was a problem hiding this comment.
Please fix the commented place. 🙏
And, is yarn.lock necessary? Please delete it if you do not need it. 👍
browser/lib/markdown.js
Outdated
|
|
||
| // FIXME We should not depend on global variable. | ||
| const katex = window.katex | ||
| var config = ConfigManager.get() |
Contributor
There was a problem hiding this comment.
Please use const instead of var.
In a modern browser, please use let or const.
Contributor
Author
|
The bug was fixed. That was only my mistake of property names. |
sosukesuzuki
approved these changes
Dec 2, 2017
Contributor
|
Thanks for your fixing! 👍 |
Contributor
Author
|
There are something to note.
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #1201. This add optional LaTeX delimiters.


However, currently this has a bug that LaTeX preference value seems not to be saved but I cannot understand. I want help to solve.