Skip to content
This repository was archived by the owner on May 12, 2026. It is now read-only.

Escape html characters before convert to HTML#1753

Merged
Rokt33r merged 1 commit into
BoostIO:masterfrom
nlopin:encode_content_in_html_export
Mar 31, 2018
Merged

Escape html characters before convert to HTML#1753
Rokt33r merged 1 commit into
BoostIO:masterfrom
nlopin:encode_content_in_html_export

Conversation

@nlopin

@nlopin nlopin commented Mar 25, 2018

Copy link
Copy Markdown

Export to HTML used to export html-like text in the note as is. The content of the note could disappear because of that.

I've added a util function escapeHtmlCharacters and use it before export. The function convert symbols "'&<> to theirs html representation: &quot;, &#39;, etc.

Fixes #1728

@Rokt33r Rokt33r self-requested a review March 25, 2018 21:07
@Rokt33r Rokt33r added the awaiting review ❇️ Pull request is awaiting a review. label Mar 25, 2018
@sosukesuzuki sosukesuzuki self-requested a review March 31, 2018 08:39

@sosukesuzuki sosukesuzuki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:+1:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants