Move note with attachment to different storage Fix for #1788#1923
Merged
Rokt33r merged 2 commits intoBoostIO:masterfrom May 16, 2018
Merged
Move note with attachment to different storage Fix for #1788#1923Rokt33r merged 2 commits intoBoostIO:masterfrom
Rokt33r merged 2 commits intoBoostIO:masterfrom
Conversation
Rokt33r
approved these changes
May 16, 2018
| const path = require('path') | ||
| const findStorage = require('browser/lib/findStorage') | ||
| const mdurl = require('mdurl') | ||
| const fse = require('fs-extra') |
Member
There was a problem hiding this comment.
Why do we need fs-extra? I assume sander can do the same job.
Contributor
Author
There was a problem hiding this comment.
I've used fs-extra because it has a good move-directory function. As far as i know sanders is not able to do so.. I think it contains some fallback implementation if the quick/efficient ways don't work..
Rokt33r
added
next release (v0.11.5)
and removed
awaiting review ❇️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Rokt33r we had a slack discussion that it is neccessary to change the note content since the noteKey is changed during the move and the attachments should be in the correct folder.
We discussed whether it is possible to simply remove this new-creation of the note key. I tried it but using the old noteKey leads to some strange issues when the app tries show the moved note. So i guess that's the reason why you initially included the new-key-feature. -> it can't be removed.
We agreed that it's a good idea to have the attachements in a folder matching the noteKey. So this PR is again needed for moving a note with its attachment.
You wished for a PR that you can auto-merge.
Here it is.