Skip to content
This repository was archived by the owner on May 12, 2026. It is now read-only.

#2042 Debounce for details renderig added#2064

Merged
sosukesuzuki merged 2 commits into
BoostIO:masterfrom
shammasov-max:debounce-markdonw-search
Jun 12, 2018
Merged

#2042 Debounce for details renderig added#2064
sosukesuzuki merged 2 commits into
BoostIO:masterfrom
shammasov-max:debounce-markdonw-search

Conversation

@shammasov-max

Copy link
Copy Markdown

I've added debounce effect for markdown preview to avoid router changes while search.
When you search smth - router chages the location ad set key of note to null.
At the next frame, router changes the key of the note.
That's way blinking has place to be.
After search - key of the note was empty - and Mardown renders nothing, at the next moment router replace the file key - and Markdown renders previous stuff
#2042

@kazup01 kazup01 added the awaiting review ❇️ Pull request is awaiting a review. label Jun 11, 2018
@sosukesuzuki sosukesuzuki self-requested a review June 12, 2018 10:48

@sosukesuzuki sosukesuzuki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks your improve!
LGTM:smile:

@sosukesuzuki sosukesuzuki merged commit 9e8ef70 into BoostIO:master Jun 12, 2018
@sosukesuzuki sosukesuzuki added next release (v0.11.6) and removed awaiting review ❇️ Pull request is awaiting a review. labels Jun 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants