Replace shortcut for 'Next Note' and 'Previous Note'#2192
Merged
Rokt33r merged 1 commit intoBoostIO:masterfrom Jul 17, 2018
Merged
Replace shortcut for 'Next Note' and 'Previous Note'#2192Rokt33r merged 1 commit intoBoostIO:masterfrom
Rokt33r merged 1 commit intoBoostIO:masterfrom
Conversation
Member
|
Sound reasonable. How do you think, @sosukesuzuki ? |
Rokt33r
approved these changes
Jul 9, 2018
Rokt33r
added
next release (v0.11.8)
and removed
awaiting review ❇️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Now shortcut key for Next Note(ctrl+J) and Previous Note(ctrl+k)had been conflicted with Emac Key map setting or sublime or vim, one of these key map settings also had It's inner use of key. like Emac using ctrl+k for repeatedly to kill multiple lines, but sublime using ctrl+k for combine action key.
also see #2133
Do
as above said, we need to change key map binding for 'Next Note' and 'Previous Note', I suggested that using CommandOrCtrl+] for 'Next Note', CommandOrCtrl+[ for 'Previous Note'.
please review.