-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
lint before commit #2456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lint before commit #2456
Conversation
|
I personally think forcing lint on commits is a bit heavy handed - our CI already runs lint so I don't think it's totally necessary. |
|
I think with pre-commit hook we can detect the problem right away without waiting for the CI to fail and prevent some unnecessary commit like "fixed lint" 😄 |
|
Maybe also have it run the tests? |
|
LGTM but can you discard |
|
@ZeroX-DG I agree with you since the tests are heavy. |
ZeroX-DG
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
This change is running the
lintcommand before a commit.