Skip to content
This repository was archived by the owner on May 12, 2026. It is now read-only.

Add ~ and _ to autoclosing brackets#2545

Merged
Rokt33r merged 4 commits into
BoostIO:masterfrom
danmou:patch-1
Mar 20, 2019
Merged

Add ~ and _ to autoclosing brackets#2545
Rokt33r merged 4 commits into
BoostIO:masterfrom
danmou:patch-1

Conversation

@danmou

@danmou danmou commented Oct 27, 2018

Copy link
Copy Markdown
Contributor

#2197 didn't add the tilde, used for strikethrough, and the alternative italic/bold underscore. Adding the underscore might be a bit annoying to some, but it's only a problem if you want to start a word with underscore (and you can always delete the extra underscore of course).

@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Oct 28, 2018
@ZeroX-DG

ZeroX-DG commented Mar 4, 2019

Copy link
Copy Markdown
Member

@danmou very sorry for the late review, can you resolve the conflict?

@danmou

danmou commented Mar 4, 2019

Copy link
Copy Markdown
Contributor Author

Done.

@ZeroX-DG ZeroX-DG left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting review ❇️ Pull request is awaiting a review. labels Mar 4, 2019
@Rokt33r Rokt33r merged commit 9f13645 into BoostIO:master Mar 20, 2019
@Rokt33r Rokt33r removed approved 👍 Pull request has been approved by sufficient reviewers. labels Mar 20, 2019
@Rokt33r Rokt33r added this to the v0.11.15 milestone Mar 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants