Merged
Conversation
… the super+shift+backspace shortcut which can be changed in the hotkey settings
…item and shortcut, updated focus note shortcut to be mac friendly, made delete note shortcut use either command+backspace or ctrl+backspace and the delete key on windows and linux machines
Member
|
LGTM but we gonna need someone with more high power to review this issue 😄 @Rokt33r |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pr initially started as adding
Clone Noteto the menu bar and having a keyboard shortcut for it. However once I got started I thought that the menu items needed some restructuring and some of the keyboard shortcuts needed to be more platform friendly (i.e. using Command on macOS vs Control on Windows\Linux). Some of the keyboard shortcut changes are listed below.Changed shortcuts
Focus Note: On macOS its now
Command+Eotherwise it remainsCtrl+EClone Note: On macOS its
Command+Dotherwise it isCtrl+DI made an attempt on bringing back the
Deletekey for non macOS machines but you can't have multiple accelerators on the same menuItem and I was too lazy to code it elsewhere 🤷♂️ I have also removed theCtrl+Dshortcut for deleting a note since the global shortcut is different as of this pr #2452 and I needed it for Clone Note 😄I also noticed from this issue #2245 that the keyboard shortcuts
wikiis seriously outdated. I can't update the wiki sadly but I hope that someone with power can do so after this PR is merged in to prevent any future confusion :)What the menu items will now look like
Clone Note proof
NOTE: I have not tested on either Linux or Windows can someone please test before merging. 🙏
Issue fixed
Type of changes
Checklist: