new feature: auto detect snippet language#2768
Merged
Rokt33r merged 2 commits intoBoostIO:masterfrom Jan 6, 2019
Merged
Conversation
only try to detect after pasting and mode has not been set and default snippet language is "Auto Detect"
Insecure Use of Regular Expressions (1)More info on how to fix Insecure Use of Regular Expressions in Javascript. Insecure Use of Language/Framework API (1)More info on how to fix Insecure Use of Language/Framework API in Javascript. |
Contributor
Author
|
@ZeroX-DG my pr can not pass the check, but what it figures out has nothing to do with what I want to change. |
Member
|
@Rokt33r Should he fix it in this PR or just leave it and you can open another PR to fix it? |
Member
|
@ZeroX-DG It should be fixed in another pr. Please ignore it. |
ZeroX-DG
reviewed
Jan 4, 2019
browser/components/CodeEditor.js
Outdated
| }) | ||
|
|
||
| this.setMode(this.props.mode) | ||
| if (!this.props.mode && this.props.value) { |
Member
There was a problem hiding this comment.
Should you check for config.editor.snippetDefaultLanguage === 'Auto Detect' here too?
ZeroX-DG
added
approved 👍
Rokt33r
added
next release (v0.11.13)
and removed
approved 👍
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
for #2351
add new feature: auto detect snippet language
try to detect after pasting and mode has not been set
Issue fixed
Type of changes
Checklist: