Skip to content

Fix #888 - Wrong word count due splitting #3226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rokt33r merged 2 commits into from
Sep 2, 2019
Merged

Fix #888 - Wrong word count due splitting #3226

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1565cee
Fix #888 - Wrong word count due splitting
thamara Aug 28, 2019
0a9db57
Fix #888 - Wrong word count due splitting
thamara Sep 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion browser/main/Detail/MarkdownNoteDetail.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -511,7 +511,7 @@ class MarkdownNoteDetail extends React.Component {
exportAsTxt={this.exportAsTxt}
exportAsHtml={this.exportAsHtml}
exportAsPdf={this.exportAsPdf}
wordCount={note.content.split(' ').length}
wordCount={note.content.replace(/\r?\n?\s+/g, ' ').trim().split(' ').length}
Copy link
Copy Markdown

@cjean-fr cjean-fr Aug 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello ! :)

I think it can be replaced by:

note.content.trim().split(/\r?\n?\s+/g).length

or even

note.content.trim().split(/\s+/g).length
since \s includes cariage returns and new lines

https://www.w3schools.com/jsref/jsref_regexp_whitespace.asp

Copy link
Copy Markdown
Member

@ZeroX-DG ZeroX-DG Sep 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thamara Can you change your code to the above suggestion for more concise code? Thanks.

Copy link
Copy Markdown
Contributor

@AWolf81 AWolf81 Sep 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I'd use the split(/s+/g).

https://repl.it/@alexanderwolf/Word-count-regex

Copy link
Copy Markdown
Contributor Author

@thamara thamara Sep 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll make the suggested change. Thanks!

letterCount={note.content.replace(/\r?\n/g, '').length}
type={note.type}
print={this.print}
Expand Down